Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Leung <[email protected]>
  • Loading branch information
rleungx committed Sep 27, 2024
1 parent cf11dfe commit 15bfdc5
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions server/api/service_middleware_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ func (suite *rateLimitConfigTestSuite) TestUpdateRateLimitConfig() {
jsonBody, err = json.Marshal(input)
re.NoError(err)
err = tu.CheckPostJSON(testDialClient, urlPrefix, jsonBody,
tu.StatusNotOK(re), tu.StringEqual(re, "\"This service is in allow list whose config can not be changed.\"\n"))
tu.StatusNotOK(re), tu.StringEqual(re, "This service is in allow list whose config can not be changed."))
re.NoError(err)
}

Expand Down Expand Up @@ -304,7 +304,7 @@ func (suite *rateLimitConfigTestSuite) TestUpdateGRPCRateLimitConfig() {
jsonBody, err = json.Marshal(input)
re.NoError(err)
err = tu.CheckPostJSON(testDialClient, urlPrefix, jsonBody,
tu.StatusOK(re), tu.StringEqual(re, "gRPC rate limiter is not changed."))
tu.StatusOK(re), tu.StringEqual(re, "gRPC limiter is not changed."))
re.NoError(err)

// change concurrency
Expand All @@ -314,13 +314,13 @@ func (suite *rateLimitConfigTestSuite) TestUpdateGRPCRateLimitConfig() {
jsonBody, err = json.Marshal(input)
re.NoError(err)
err = tu.CheckPostJSON(testDialClient, urlPrefix, jsonBody,
tu.StatusOK(re), tu.StringContain(re, "gRPC rate limiter is updated."))
tu.StatusOK(re), tu.StringContain(re, "gRPC limiter is updated."))
re.NoError(err)
input["concurrency"] = 0
jsonBody, err = json.Marshal(input)
re.NoError(err)
err = tu.CheckPostJSON(testDialClient, urlPrefix, jsonBody,
tu.StatusOK(re), tu.StringContain(re, "gRPC rate limiter is deleted."))
tu.StatusOK(re), tu.StringContain(re, "gRPC limiter is deleted."))
re.NoError(err)

// change qps
Expand All @@ -330,7 +330,7 @@ func (suite *rateLimitConfigTestSuite) TestUpdateGRPCRateLimitConfig() {
jsonBody, err = json.Marshal(input)
re.NoError(err)
err = tu.CheckPostJSON(testDialClient, urlPrefix, jsonBody,
tu.StatusOK(re), tu.StringContain(re, "gRPC rate limiter is updated."))
tu.StatusOK(re), tu.StringContain(re, "gRPC limiter is updated."))
re.NoError(err)

input = make(map[string]any)
Expand All @@ -339,15 +339,15 @@ func (suite *rateLimitConfigTestSuite) TestUpdateGRPCRateLimitConfig() {
jsonBody, err = json.Marshal(input)
re.NoError(err)
err = tu.CheckPostJSON(testDialClient, urlPrefix, jsonBody,
tu.StatusOK(re), tu.StringContain(re, "gRPC rate limiter is updated."))
tu.StatusOK(re), tu.StringContain(re, "gRPC limiter is updated."))
re.NoError(err)
re.Equal(1, suite.svr.GetGRPCRateLimitConfig().LimiterConfig["StoreHeartbeat"].QPSBurst)

input["qps"] = -1
jsonBody, err = json.Marshal(input)
re.NoError(err)
err = tu.CheckPostJSON(testDialClient, urlPrefix, jsonBody,
tu.StatusOK(re), tu.StringContain(re, "gRPC rate limiter is updated."))
tu.StatusOK(re), tu.StringContain(re, "gRPC limiter is updated."))
re.NoError(err)

// change both
Expand Down

0 comments on commit 15bfdc5

Please sign in to comment.