address the comment

Signed-off-by: Ryan Leung <[email protected]>
tikv · Aug 12, 2024 · 059b18e · 059b18e
1 parent 01372dc
commit 059b18e
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 4 deletions.
diff --git a/pkg/mcs/resourcemanager/server/server.go b/pkg/mcs/resourcemanager/server/server.go
@@ -113,7 +113,6 @@ func (s *Server) Run() (err error) {
 		return err
 	}
 
-	// register
 	if s.clusterID, s.serviceID, s.serviceRegister, err = utils.Register(s, constant.ResourceManagerServiceName); err != nil {
 		return err
 	}

diff --git a/pkg/mcs/scheduling/server/server.go b/pkg/mcs/scheduling/server/server.go
@@ -149,7 +149,6 @@ func (s *Server) Run() (err error) {
 		return err
 	}
 
-	// register
 	if s.clusterID, s.serviceID, s.serviceRegister, err = utils.Register(s, constant.SchedulingServiceName); err != nil {
 		return err
 	}

diff --git a/pkg/mcs/server/server.go b/pkg/mcs/server/server.go
@@ -100,7 +100,7 @@ func (bs *BaseServer) SetEtcdClient(etcdClient *clientv3.Client) {
 	bs.etcdClient = etcdClient
 }
 
-// SetETCDClient sets the etcd client.
+// GetEtcdClient returns the etcd client.
 func (bs *BaseServer) GetEtcdClient() *clientv3.Client {
 	return bs.etcdClient
 }

diff --git a/pkg/mcs/tso/server/server.go b/pkg/mcs/tso/server/server.go
@@ -156,7 +156,6 @@ func (s *Server) Run() (err error) {
 		return err
 	}
 
-	// register
 	if s.clusterID, s.serviceID, s.serviceRegister, err = utils.Register(s, constant.TSOServiceName); err != nil {
 		return err
 	}

diff --git a/pkg/mcs/utils/util.go b/pkg/mcs/utils/util.go
@@ -278,6 +278,7 @@ func StopGRPCServer(s server) {
 	}
 }
 
+// Register registers the service.
 func Register(s server, serviceName string) (uint64, *discovery.ServiceRegistryEntry, *discovery.ServiceRegister, error) {
 	var (
 		clusterID uint64