transaction: allow cleanup after the connection is killed (WIP, DNM) #1424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
the
dco-signoff: yes
13 tasks
YangKeao
commented
Aug 14, 2024
| @@ -1638,6 +1644,10 @@ func (c *twoPhaseCommitter) execute(ctx context.Context) (err error) { | |||
| return err | |||
| } | |||
|
|
|||
| if c.txn.resourceGroupName == "testslowcommit" { | |||
There was a problem hiding this comment.
Some dirty codes for test. @YangKeao please remember to remove it later.
Signed-off-by: Yang Keao <[email protected]>
YangKeao
force-pushed
the
fix-stale-lock
branch
from
e2c6441
to
0f240d6
Compare
|
It's better to add hooks to wait for background goroutines. #1432. This PR doesn't work, and I'm not going to investigate it. Close now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixed two issues:
cleanuplogic doesn't take effect for the commit in async commit stage. (Though, I'm not sure whether it's a mistake or by design. It seems good now.)cleanupto run after the connection is killed. This makes it possible to clean up the lock before TiDB shutdown.