Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: clean code #1147

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
+3 −4
Open

*: clean code #1147

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9183f9e
*: remove redundant go_test
hawkingrei Jan 31, 2024
002b527
*: clean code
hawkingrei Jan 28, 2024
664e78a
*: remove redundant go_test
hawkingrei Jan 30, 2024
fdb029c
*: remove redundant go_test
hawkingrei Jan 31, 2024
8408cd6
*: remove redundant go_test
hawkingrei Jan 31, 2024
a6b67c2
202402022
hawkingrei Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions internal/locate/region_cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ import (
"math"
"math/rand"
"slices"
"sort"
"strconv"
"strings"
"sync"
Expand Down Expand Up @@ -1049,13 +1048,13 @@ func (l *KeyLocation) LocateBucket(key []byte) *Bucket {
func (l *KeyLocation) locateBucket(key []byte) *Bucket {
keys := l.Buckets.GetKeys()
searchLen := len(keys) - 1
i := sort.Search(searchLen, func(i int) bool {
return bytes.Compare(key, keys[i]) < 0
i, found := slices.BinarySearchFunc(keys, key, func(a, b []byte) int {
return bytes.Compare(a, b)
})

// buckets contains region's start/end key, so i==0 means it can't find a suitable bucket
// which can happen if the bucket information is stale.
if i == 0 ||
if (!found && i == 0) ||
// the key isn't located in the last range.
(i == searchLen && len(keys[searchLen]) != 0 && bytes.Compare(key, keys[searchLen]) >= 0) {
return nil
Expand Down
Loading