refactor: multigrid ndt omp pure refactoring #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shintaro Sakoda <[email protected]>
Signed-off-by: anhnv3991 <[email protected]>
anhnv3991
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
@SakodaShintaro I just removed the underbar at the end of names of some variables, such as point_gradient_ to point_gradient, point_hessian_ to point_hessian.
Basically the underbar are put to the end of class-member variables. In the original NDT implementation of PCL, point_gradient_ and point_hessian_ are members of the NDT class, but in tier4's repo they are not.
Test was OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have extracted changes that do not result in numerical changes from the pull request below.
#32