Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a regression test #33

Merged
merged 22 commits into from
Mar 11, 2024
Merged

feat: add a regression test #33

merged 22 commits into from
Mar 11, 2024

Conversation

SakodaShintaro
Copy link

@SakodaShintaro SakodaShintaro commented Mar 10, 2024 •
edited
Loading

Added a regression_test to test changes in ndt_omp.

Sample data

Evaluation perspective

The speed is almost the same compared to previous results.

elapsed_milliseconds

Accuracy must match the previous results completely or to some extent

elapsed_milliseconds_ratio_mean=0.969 (current / reference)
The scores are perfectly the same.
OK

Main files added

  • python script to build pcd and ekf_pose pair from rosbag
  • cpp code to execute align
  • python script to compare two results

@SakodaShintaro
Added a regression_test
0b3906e 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Fixed CMakeLists.txt
97927f2 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Fixed return
38cfba2 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro SakodaShintaro self-assigned this Mar 10, 2024
@Motsu-san
Copy link

Motsu-san commented Mar 11, 2024 •
edited
Loading

@SakodaShintaro

The speed is almost the same compared to previous results.

What is "the speed"? Processing time? If so, could you let us know what to measure time from and to?

@SakodaShintaro
Copy link
Author

@Motsu-san
Speed means the average processing time of the align function.
https://github.com/tier4/ndt_omp/pull/33/files#diff-26c50a24f97f4a3d9417c081618754353b5cb41c783c13348a71005e63d6dc58R114-R117

@SakodaShintaro
Updated README.md
a78aa7f 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added download_data.sh
a04e89d 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added regression_test.yml
ee07a73 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Fixed dir name
7378bba 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added container
9ba1e3a 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added "Install dependencies"
fc78aaa 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added quiet
0eacf9c 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added unzip
ea95135 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added -q to unzip
caa968c 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added source
74b2bb4 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Fixed path
4c00db8 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added "shell: bash"
fa6b525 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added libpcl-dev
f1dfcac 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added python dependencies
da85f78 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added reference/result.csv
186ee31 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added python3-pip
d1c3ba1 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Added Upload output files
5f60159 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Fixed name and execute if
9ecdb9f 
Signed-off-by: Shintaro Sakoda <[email protected]>
@SakodaShintaro
Updated result by GitHub Actions result
7eaded1 
Signed-off-by: Shintaro Sakoda <[email protected]>
anhnv3991
anhnv3991 approved these changes Mar 11, 2024
View reviewed changes
Copy link

@anhnv3991 anhnv3991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SakodaShintaro LGTM!

@SakodaShintaro SakodaShintaro merged commit 6c6d0e1 into tier4/main Mar 11, 2024
10 checks passed
@SakodaShintaro SakodaShintaro deleted the feat/add_test branch March 11, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anhnv3991 anhnv3991 anhnv3991 approved these changes

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo

Assignees

@SakodaShintaro SakodaShintaro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SakodaShintaro @Motsu-san @anhnv3991