feat: jazzy support #306
feat: jazzy support #306
Conversation
CARET_trace/src/ros_trace_points.cpp
Outdated
| void ros_trace_rmw_publish( | ||
| const void * rmw_publisher_handle, | ||
| const void * message, | ||
| int64_t init_timestamp |
There was a problem hiding this comment.
Following the definition of ros2_tracing the variable name should be changed as follows.
| int64_t init_timestamp | |
| int64_t timestamp |
There was a problem hiding this comment.
variable name changed
| @@ -43,6 +43,22 @@ TRACEPOINT_EVENT( | |||
| ) | |||
| ) | |||
|
|
|||
| #ifdef ROS_DISTRO_JAZZY | |||
| TRACEPOINT_EVENT( | |||
There was a problem hiding this comment.
Following the definition of ros2_tracing the variable name should be changed init_timestamp to timestamp
https://github.com/ros2/ros2_tracing/blob/jazzy/tracetools/include/tracetools/tracetools.h#L283
There was a problem hiding this comment.
variable name changed
| const std::string executor_type_name = "single_threaded_executor"; | ||
|
|
| #ifdef DEBUG_OUTPUT | ||
| // std::cerr << "callback_group_to_executor_entity_collector," << obj << "," << group_addr << | ||
| // std::endl; | ||
| #endif |
There was a problem hiding this comment.
The information in this line is useful and should not be commented out.
| return; | ||
| } | ||
|
|
||
| const std::string executor_type_name = "single_threaded_executor"; |
| /// @brief Store data for callback_group_to_executor_entity_collector trace points. | ||
| /// @tparam ...Args Data types to be stored. | ||
| /// @param ...args Data to be stored. | ||
| /// @return True, data was stored to pending set. | ||
| /// @return False, data was stored to set. | ||
| template <typename... Args> | ||
| bool store_callback_group_to_executor_entity_collector(Args... args) | ||
| { | ||
| return callback_group_to_executor_entity_collector_->store(args...); | ||
| } | ||
|
|
||
| /// @brief Store data for executor_entity_collector_to_executor trace points. | ||
| /// @tparam ...Args Data types to be stored. | ||
| /// @param ...args Data to be stored. | ||
| /// @return True, data was stored to pending set. | ||
| /// @return False, data was stored to set. | ||
| template <typename... Args> | ||
| bool store_executor_entity_collector_to_executor(Args... args) | ||
| { | ||
| return executor_entity_collector_to_executor_->store(args...); | ||
| } |
There was a problem hiding this comment.
It may need to be a conditional compilation.
There was a problem hiding this comment.
conditional compilation applied
|
|
||
| /// @brief Check whether recording function for callback_group_to_executor_entity_collector trace | ||
| /// point is assigned. | ||
| /// @return True if function is assigned, false otherwise. | ||
| bool is_assigned_callback_group_to_executor_entity_collector() const; | ||
|
|
||
| /// @brief Check whether recording function for executor_entity_collector_to_executor trace point | ||
| /// is assigned. | ||
| /// @return True if function is assigned, false otherwise. | ||
| bool is_assigned_executor_entity_collector_to_executor() const; |
There was a problem hiding this comment.
It may need to be a conditional compilation.
There was a problem hiding this comment.
conditional compilation applied
| /// @brief Assign recording function for callback_group_to_executor_entity_collector trace points. | ||
| /// @param record recording function. | ||
| void assign_callback_group_to_executor_entity_collector( | ||
| CallbackGroupToExecutorEntityCollector::StdFuncT record); | ||
|
|
||
| /// @brief Assign recording function for executor_entity_collector_to_executor trace points. | ||
| /// @param record recording function. | ||
| void assign_executor_entity_collector_to_executor( | ||
| ExecutorEntityCollectorToExecutor::StdFuncT record); | ||
|
|
There was a problem hiding this comment.
It may need to be a conditional compilation.
There was a problem hiding this comment.
conditional compilation applied
| std::shared_ptr<CallbackGroupToExecutorEntityCollector::KeysT> | ||
| callback_group_to_executor_entity_collector_; | ||
| std::shared_ptr<ExecutorEntityCollectorToExecutor::KeysT> executor_entity_collector_to_executor_; |
There was a problem hiding this comment.
It may need to be a conditional compilation.
There was a problem hiding this comment.
conditional compilation applied
| return; | ||
| } | ||
|
|
||
| if (trace_filter_is_rcl_publish_recorded) { |
There was a problem hiding this comment.
The following is one of the suggestions for implementation improvement.
I don't think it's necessary to include this in the current PR, but I'll leave it as text for reference.
Until now, we've been determining whether to apply the filter for rmw_publish (=dds_write) based on the presence or absence of rcl_publish records.
However, from jazzy onwards, we can obtain rmw_publish.
Using rmw_publish for filtering might enable a more appropriate implementation.
There was a problem hiding this comment.
no particular corrections made to this issue
Description
jazzy support
Related links
https://tier4.atlassian.net/browse/RT2-1803
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.