Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uninitialized variables #290

Closed
wants to merge 2 commits into from

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented Jun 14, 2024

Description

Of the clang-tidy pointers, the following items should be checked

  • misc-unused-parameters
  • cppcoreguidelines-init-variables (uninitialised variables)
  • cppcoreguidelines-pro-type-member-init (uninitialised member variables)
  • cppcoreguidelines-narrowing-conversions (precision loss)
    Code checks extracted two cases of code to be corrected in relation to cppcoreguidelines-init-variables.

Related links

https://tier4.atlassian.net/browse/RT2-738

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xygyo77 xygyo77 requested a review from ymski June 14, 2024 02:52
@xygyo77 xygyo77 force-pushed the fix_uninitialized_variables branch 2 times, most recently from 7e0ae45 to 8a2d81c Compare June 14, 2024 06:59
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.05%. Comparing base (75e1c3f) to head (6260007).
Report is 18 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #290       +/-   ##
===========================================
+ Coverage   25.02%   55.05%   +30.03%     
===========================================
  Files          58       28       -30     
  Lines        3321     2185     -1136     
  Branches     1085     1217      +132     
===========================================
+ Hits          831     1203      +372     
+ Misses       1756      702     -1054     
+ Partials      734      280      -454     
Flag Coverage Δ
differential 55.05% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xygyo77
Copy link
Contributor Author

xygyo77 commented Jun 17, 2024

This PR is not merged and closed as there are no operational problems without this modification.

@xygyo77 xygyo77 closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants