Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: controlling the dds_bind_addr_to_stamp output of generic_publish() #288

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented Jun 3, 2024

The dds_bind_addr_to_stamp output of generic_publish() is controlled as follows.

  • Before jazzy: Always output.
  • After jazzy: Those associated with rcl_publish are subject to the filter.

Related links

https://tier4.atlassian.net/browse/RT2-1640

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

… jazzy; after jazzy, it checks the connection with rcl_publish and outputs it.

Signed-off-by: ISP akm <[email protected]>
@xygyo77 xygyo77 requested a review from ymski June 3, 2024 09:14
@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 55.05%. Comparing base (75e1c3f) to head (a4095ce).
Report is 17 commits behind head on main.

Files Patch % Lines
CARET_trace/src/hooked_trace_points.cpp 0.00% 6 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #288       +/-   ##
===========================================
+ Coverage   25.02%   55.05%   +30.03%     
===========================================
  Files          58       28       -30     
  Lines        3321     2185     -1136     
  Branches     1085     1213      +128     
===========================================
+ Hits          831     1203      +372     
+ Misses       1756      702     -1054     
+ Partials      734      280      -454     
Flag Coverage Δ
differential 55.05% <0.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@miyakoshi-dev miyakoshi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xygyo77 xygyo77 merged commit 93b881e into tier4:main Jun 4, 2024
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants