Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: special duplicate check removal using static variables #284

Merged
merged 1 commit into from
May 14, 2024

Conversation

miyakoshi-dev
Copy link
Contributor

@miyakoshi-dev miyakoshi-dev commented May 13, 2024

Description

special duplicate check removal using static variables

Related links

https://tier4.atlassian.net/browse/RT2-1529

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.36%. Comparing base (75e1c3f) to head (dff7f08).
Report is 14 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #284       +/-   ##
===========================================
+ Coverage   25.02%   54.36%   +29.33%     
===========================================
  Files          58       28       -30     
  Lines        3321     2213     -1108     
  Branches     1085     1228      +143     
===========================================
+ Hits          831     1203      +372     
+ Misses       1756      732     -1024     
+ Partials      734      278      -456     
Flag Coverage Δ
differential 54.36% <100.00%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miyakoshi-dev miyakoshi-dev requested a review from ymski May 13, 2024 04:35
@ymski ymski requested a review from xygyo77 May 14, 2024 01:09
Copy link
Contributor

@xygyo77 xygyo77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miyakoshi-dev miyakoshi-dev merged commit 76c6c87 into tier4:main May 14, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants