Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ignore processes filter #273

Merged
merged 6 commits into from
Mar 22, 2024

Conversation

xygyo77
Copy link
Contributor

@xygyo77 xygyo77 commented Mar 7, 2024

Description

Traces of processes listed in the environment variable CARET_IGNORE_PROCESSES are filtered.

Related links

https://tier4.atlassian.net/browse/RT2-1382

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xygyo77 xygyo77 requested a review from isp-uetsuki March 7, 2024 08:44
CARET_trace/include/caret_trace/tracing_controller.hpp Outdated Show resolved Hide resolved
CARET_trace/src/tracing_controller.cpp Outdated Show resolved Hide resolved
CARET_trace/src/tracing_controller.cpp Outdated Show resolved Hide resolved
CARET_trace/src/tracing_controller.cpp Outdated Show resolved Hide resolved
CARET_trace/src/trace_node.cpp Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 19.69697% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 58.70%. Comparing base (75e1c3f) to head (70fbecd).
Report is 2 commits behind head on main.

Files Patch % Lines
CARET_trace/src/ros_trace_points.cpp 5.71% 15 Missing and 18 partials ⚠️
CARET_trace/src/hooked_trace_points.cpp 27.27% 8 Missing and 8 partials ⚠️
CARET_trace/src/tracing_controller.cpp 55.55% 1 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #273       +/-   ##
===========================================
+ Coverage   25.02%   58.70%   +33.68%     
===========================================
  Files          58       28       -30     
  Lines        3321     1930     -1391     
  Branches     1085     1120       +35     
===========================================
+ Hits          831     1133      +302     
+ Misses       1756      553     -1203     
+ Partials      734      244      -490     
Flag Coverage Δ
differential 58.70% <19.69%> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@isp-uetsuki isp-uetsuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@miyakoshi-dev miyakoshi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xygyo77 xygyo77 merged commit b64a58f into tier4:main Mar 22, 2024
12 of 14 checks passed
@xygyo77 xygyo77 deleted the feat/add_ignore_processes_filter branch March 22, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants