Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lane_change): cherry-pick lane change commits to beta/v0.29.0 #537

Merged
merged 3 commits into from
Aug 16, 2024

Conversation

zulfaqar-azmi-t4
Copy link

Description

launcher for tier4/autoware.universe#1441

ROS Parameter Changes

Additions and removals

Change type Parameter Name Type Default Value Description
Added finish_judge_lateral_angle_deviation double 1.0 lateral angle threshold to determine lane change completion
Added parked.expected_front_deceleration double -1.0 The front object's maximum deceleration when the front vehicle perform sudden braking
Added parked.expected_rear_deceleration double -2.0 The rear object's maximum deceleration when the rear vehicle perform sudden braking.
Added parked.rear_vehicle_reaction_time double 1.0 The reaction time of the rear vehicle driver which starts from the driver noticing the sudden braking of the front vehicle until the driver step on the brake.
Added parked.rear_vehicle_safety_time_margin double 0.8 The time buffer for the rear vehicle to come into complete stop when its driver perform sudden braking.
Added parked.lateral_distance_max_threshold double 1.0 The lateral distance threshold that is used to determine whether lateral distance between two object is enough and whether lane change is safe.
Added parked.longitudinal_distance_min_threshold double 3.0 The longitudinal distance threshold that is used to determine whether longitudinal distance between two object is enough and whether lane change is safe.
Added parked.longitudinal_velocity_delta_time double 0.0 The time multiplier that is used to compute the actual gap between vehicle at each predicted points (not RSS distance)
Added skip_process.longitudinal_distance_diff_threshold.prepare double 1.0 prepare longitudinal distance threshold to skip path planning
Added skip_process.longitudinal_distance_diff_threshold.lane_changing double 1.0 lane changing longitudinal distance threshold to skip path planning

Modifications

Version Parameter Name Type Default Value Description
Old finish_judge_lateral_threshold double 0.2 lateral threshold to determine lane change completion
New finish_judge_lateral_threshold double 0.1 lateral threshold to determine lane change completion

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ndation#1087)

* RT1-6514 adding lateral angle deviation param

Signed-off-by: Zulfaqar Azmi <[email protected]>

* decrease angle deviation threshold to fix rtc issue

Signed-off-by: Zulfaqar Azmi <[email protected]>

---------

Signed-off-by: Zulfaqar Azmi <[email protected]>
autowarefoundation#1104)

use separate rss for parked vehicle

Signed-off-by: Muhammad Zulfaqar Azmi <[email protected]>
…rence is less than threshold (autowarefoundation#1108)

add skip process lon dist diff threshold

Signed-off-by: Zulfaqar Azmi <[email protected]>
Copy link

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zulfaqar-azmi-t4 cc. @Naophis
Thank you so much! I'd like to merge this after v0.46.0 release this week. Until that let me change this PR to draft 🙏

@shmpwk shmpwk marked this pull request as draft August 13, 2024 03:23
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 marked this pull request as ready for review August 15, 2024 14:38
@zulfaqar-azmi-t4
Copy link
Author

@Naophis @shmpwk
I saw the main PR is merged, please don't forget to merge this as well. 🙏🏼

Copy link

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shmpwk shmpwk merged commit 0a16746 into beta/v0.29.0 Aug 16, 2024
10 checks passed
@shmpwk shmpwk deleted the cp-lane-change-longitudinal-filter branch August 16, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants