Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(detection_area): search collision index only in lanelet #695

Merged
merged 4 commits into from
Aug 25, 2023
Merged

fix(detection_area): search collision index only in lanelet #695

merged 4 commits into from
Aug 25, 2023

Conversation

h-ohta
Copy link

@h-ohta h-ohta commented Jul 28, 2023 •
edited
Loading

Description

autowarefoundation#405 を参考に

Detection Areaに紐づく停止線の挿入位置を間違えないようにするために

  • Detection AreaをRegulatory Elementとして持つlaneletのidを変数として保持
  • Detection Areaの停止線と交差する経路位置の探索を、上記idのlanelet内に限定する

これにより、「1つのlaneletにおいて重複が発生し、かつ重複している場所にdetection_areaがある」の場合を除けば停止線の位置を間違えることはなくなる

図示すると以下の通り
b862c969-3c38-4cc3-b35e-02043901a6dc

Related links

https://tier4.atlassian.net/browse/AEAP-685

Tests performed

経路が重複する位置にdetection areaが設定されている地図においてAfterのとおりになることを確認した

Before:

output-2023-07-27_10.03.36.mp4

After:

output-2023-07-28_17.22.01.mp4

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-ohta h-ohta marked this pull request as ready for review August 3, 2023 07:23
@h-ohta h-ohta requested review from asa-naki, sfukuta and yn-mrse and removed request for yn-mrse August 25, 2023 02:15
@asa-naki
Copy link

もし仮に往路用にDetection Areaがもう１つ設置されて右側の停止線でのstop_line付近にDetectionAreaの停止線が入ってた地図が新しく運用されても、今回の修正によってそちらも対応できるということになるのでしょうか？

@h-ohta
Copy link
Author

h-ohta commented Aug 25, 2023

@asa-naki ちょっと具体的なイメージが浮かばないので、もう少しどういう状況を考えているか、図などでせつめいいただけるとありがたいです

@asa-naki
Copy link

image

@h-ohta
Copy link
Author

h-ohta commented Aug 25, 2023 •
edited
Loading

画像確認しました。今回の修正では、その停止線が属するlaneletの中でのみ、停止線を挿入する位置を探すこととなります。
なので、画像の場合についても往路側のDAは往路側のstoplineと紐付いていて、往路側のlaneletに属するのであれば、対応が出来ています

@asa-naki
Copy link

画像確認しました。今回の修正では、その停止線が属するlaneletの中でのみ、停止線を挿入する位置を探すこととなります。
なので、画像の場合についても往路側のDAは往路側のstoplineと紐付いていて、往路側のlaneletに属するのであれば、対応が出来ています

であればLGTMです！

@h-ohta h-ohta enabled auto-merge (squash) August 25, 2023 08:33
@h-ohta h-ohta merged commit 66f333e into beta/v0.3.17 Aug 25, 2023
6 of 7 checks passed
@h-ohta h-ohta deleted the fix/detection_area_loop branch August 25, 2023 08:34
@h-ohta h-ohta mentioned this pull request Oct 12, 2023
Merged
7 tasks
asa-naki pushed a commit that referenced this pull request Aug 14, 2024
@h-ohta @pre-commit-ci @asa-naki
fix(detection_area): search collision index only in lanelet (#695)
6ac6719 
* fix(detection_area): search collision index only in lanelet

* ci(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This was referenced Aug 27, 2024
Closed
Merged
asa-naki added a commit that referenced this pull request Aug 29, 2024
@asa-naki @TakaHoribe
@pre-commit-ci @sfukuta @h-ohta @ito-san @Shin-kyoto @Owen-Liuyuxuan @takeshi-iwanari @kminoda @esteve
feat: resource check (#1496)
a5b62af 
* feat(system_error_monitor): manual modules (#793)

* feat(rviz_plugin): console meter is too large on the Rviz with FHD display, isn't it? (#587)

* feat(tier4_planning/vehicle_plugin): make plugins size scalable

Signed-off-by: Takamasa Horibe <[email protected]>

* remove space

Signed-off-by: Takamasa Horibe <[email protected]>

* scaling

Signed-off-by: Takamasa Horibe <[email protected]>

* change diag message

Signed-off-by: asa-naki <[email protected]>

* fix module name

Signed-off-by: asa-naki <[email protected]>

* add manual module and ignoring modules

Signed-off-by: asa-naki <[email protected]>

* Revert "feat(rviz_plugin): console meter is too large on the Rviz with FHD display, isn't it? (#587)"

This reverts commit f96169c.

* Revert "change diag message"

This reverts commit dff01ce.

* ci(pre-commit): autofix

* fix spell check

Signed-off-by: asa-naki <[email protected]>

* Revert "fix spell check"

This reverts commit 208aa1e.

* Revert "fix module name"

This reverts commit cec7653.

* revert ignore module

Signed-off-by: asa-naki <[email protected]>

* current_mode check update

Signed-off-by: asa-naki <[email protected]>

* ci(pre-commit): autofix

* delete margin

Signed-off-by: asa-naki <[email protected]>

---------

Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: asa-naki <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(ad_service_state_monitor): change configs name (#876)

change configs name

Signed-off-by: asa-naki <[email protected]>

* feat(plannig_error_monitor): update error sharp angle threshold (#681)

* fix error_sharp_angle

Signed-off-by: Shigekazu Fukuta <[email protected]>

* update readme

Signed-off-by: Shigekazu Fukuta <[email protected]>

---------

Signed-off-by: Shigekazu Fukuta <[email protected]>

* fix: add error handling when path is invalid (#934)

* fix(behavior_path): delete duplicated

* add error handling

* fix: when path size is 1

* fix(detection_area): search collision index only in lanelet (#695)

* fix(detection_area): search collision index only in lanelet

* ci(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(detection_area): fix overline function (#930)

* fix(detection_area): fix overline function

* ci(pre-commit): autofix

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(route_handler): fix threshold for removing overlapping points (#1015)

* fix(route_handler): fix threshold for removing overlapping points

* fix

* fix(ntp_monitor): move chronyc command execution to a timer (backport autowarefoundation#4634) (#880)

fix(ntp_monitor): move chronyc command execution to a timer (autowarefoundation#4634)

* fix(ntp_monitor): move chronyc command execution to a timer



* add newly added parameter timeout to config

---------

Signed-off-by: ito-san <[email protected]>
Co-authored-by: ito-san <[email protected]>

* feat(elevation_map_loader): add error handling for std::runtime_error (backport autowarefoundation#4187) (#652)

feat(elevation_map_loader): add error handling for std::runtime_error (autowarefoundation#4187)

* feat(elevation_map_loader): Add error handling for std::runtime_error



* feat(elevation_map_loader): add error message output



---------

Signed-off-by: Shin-kyoto <[email protected]>
Co-authored-by: Shintaro Tomie <[email protected]>

* fix(system_monitor): extend command line to display (backport autowarefoundation#4553) (#768)

fix(system_monitor): extend command line to display (autowarefoundation#4553)

Signed-off-by: ito-san <[email protected]>
Co-authored-by: ito-san <[email protected]>

* fix(system_monitor): high-memory process are not provided in MEM order (backport autowarefoundation#4654) (#769)

fix(system_monitor): high-memory process are not provided in MEM order (autowarefoundation#4654)

* fix(process_monitor): high-memory process are not being provided in %MEM order



* changed option from 'g' to 'n'



---------

Signed-off-by: ito-san <[email protected]>
Co-authored-by: ito-san <[email protected]>

* fix(system_monitor): fix program command line reading (backport autowarefoundation#5191, autowarefoundation#5430) (#995)

* perf(system_monitor): fix program command line reading (autowarefoundation#5191)

* Fix program command line reading

Signed-off-by: Owen-Liuyuxuan <[email protected]>

* style(pre-commit): autofix

* fix spelling commandline->command_line

Signed-off-by: Owen-Liuyuxuan <[email protected]>

---------

Signed-off-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* fix(system_monitor): output command line (autowarefoundation#5430)

* fix(system_monitor): output command line

Signed-off-by: takeshi.iwanari <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: takeshi.iwanari <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: takeshi.iwanari <[email protected]>
Co-authored-by: Yuxuan Liu <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: takeshi-iwanari <[email protected]>
Co-authored-by: Akihisa Nagata <[email protected]>

* feat(imu_corrector): add gyro_bias_validator (backport autowarefoundation#4729) (#856)

* feat(imu_corrector): add gyro_bias_validator (backport autowarefoundation#4729)
* feat(imu_corrector): add gyro_bias_validator
Signed-off-by: kminoda <[email protected]>
* style(pre-commit): autofix
* update
Signed-off-by: kminoda <[email protected]>
* revert launch
Signed-off-by: kminoda <[email protected]>
* updat
Signed-off-by: kminoda <[email protected]>
* style(pre-commit): autofix
* add debug publisher
Signed-off-by: kminoda <[email protected]>
* minor fix
Signed-off-by: kminoda <[email protected]>
* style(pre-commit): autofix
* style(pre-commit): autofix
* add gtest
Signed-off-by: kminoda <[email protected]>
* style(pre-commit): autofix
* updat e readme
Signed-off-by: kminoda <[email protected]>
* style(pre-commit): autofix
* add diagnostics
Signed-off-by: kminoda <[email protected]>
* style(pre-commit): autofix
* update
Signed-off-by: kminoda <[email protected]>
* style(pre-commit): autofix
* validator -> estimator
Signed-off-by: kminoda <[email protected]>
* fix build
Signed-off-by: kminoda <[email protected]>
* update default parameter
Signed-off-by: kminoda <[email protected]>
* update comment
Signed-off-by: kminoda <[email protected]>
* update readme
Signed-off-by: kminoda <[email protected]>
* style(pre-commit): autofix
* updated
Signed-off-by: kminoda <[email protected]>
* minor update in readme
Signed-off-by: kminoda <[email protected]>
* style(pre-commit): autofix
* fix pre-commit
Signed-off-by: kminoda <[email protected]>
* update readme
Signed-off-by: kminoda <[email protected]>
* style(pre-commit): autofix
* Fix NG -> WARN
Signed-off-by: kminoda <[email protected]>
---------
Signed-off-by: kminoda <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Signed-off-by: asa-naki <[email protected]>

* build(imu_corrector): add missing diagnostic_updater dependency (autowarefoundation#4980)

Signed-off-by: Esteve Fernandez <[email protected]>

* add gyro_bias estimation in diag ( autowarefoundation#5054)

Signed-off-by: asa-naki <[email protected]>

* ci(pre-commit): autofix

---------

Signed-off-by: asa-naki <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: kminoda <[email protected]>
Co-authored-by: Esteve Fernandez <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(imu_corrector): add gyro bias log (#918)

add gyro_bias log

Signed-off-by: asa-naki <[email protected]>

* feat(system_error_monitor): add ignore_until_waiting_for_route module (#888)

* add ignore_module

Signed-off-by: asa-naki <[email protected]>

* add description

Signed-off-by: asa-naki <[email protected]>

* ci(pre-commit): autofix

* change name ignore_until_waiting_for_route

Signed-off-by: asa-naki <[email protected]>

* update description

Signed-off-by: asa-naki <[email protected]>

* rename function name and delete planning state

Signed-off-by: asa-naki <[email protected]>

* update description

Signed-off-by: asa-naki <[email protected]>

* Update

---------

Signed-off-by: asa-naki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Hiroki OTA <[email protected]>

* feat(system_error_monitor): add ignore hartbeat timeout in initializing state (#972)

* add ignore hartbeat timeout in initializing state

Signed-off-by: asa-naki <[email protected]>

* fix typo

* Update comment

* ci(pre-commit): autofix

* fix typo

* ci(pre-commit): autofix

* update comment

* ci(pre-commit): autofix

---------

Signed-off-by: asa-naki <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

---------

Signed-off-by: Takamasa Horibe <[email protected]>
Signed-off-by: asa-naki <[email protected]>
Signed-off-by: Shigekazu Fukuta <[email protected]>
Signed-off-by: ito-san <[email protected]>
Signed-off-by: Shin-kyoto <[email protected]>
Signed-off-by: Owen-Liuyuxuan <[email protected]>
Signed-off-by: takeshi.iwanari <[email protected]>
Signed-off-by: Esteve Fernandez <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Shigekazu Fukuta <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: ito-san <[email protected]>
Co-authored-by: Shintaro Tomie <[email protected]>
Co-authored-by: Yuxuan Liu <[email protected]>
Co-authored-by: Owen-Liuyuxuan <[email protected]>
Co-authored-by: takeshi-iwanari <[email protected]>
Co-authored-by: kminoda <[email protected]>
Co-authored-by: Esteve Fernandez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asa-naki asa-naki asa-naki approved these changes

@YoheiMishina YoheiMishina Awaiting requested review from YoheiMishina

@sfukuta sfukuta Awaiting requested review from sfukuta

@yn-mrse yn-mrse Awaiting requested review from yn-mrse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-ohta @asa-naki