Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(autoware_map_based_prediction autoware_universe_utils): improve performance of map_based_prediction #1464

Conversation

yucedagonurcan and others added 9 commits August 15, 2024 09:56
…ation#8031)

fix(autoware_map_based_prediction): fix argument order in call `getFrenetPoint()`

Signed-off-by: yucedagonurcan <[email protected]>

Co-authored-by: Shintaro Tomie <[email protected]>
Co-authored-by: Kotaro Uetake <[email protected]>
…ndation#8416)

perf: apply lerp interpolation instead of spline

Signed-off-by: Kotaro Uetake <[email protected]>
…and resample converted path (autowarefoundation#8427)

* refactor: improve orientation calculation and resample converted path with linear interpolation

Simplify the calculation of the orientation for each pose in the convertPathType function by directly calculating the sine and cosine of half the yaw angle. This improves efficiency and readability. Also, improve the resampling of the converted path by using linear interpolation for better performance.

Signed-off-by: Taekjin LEE <[email protected]>

* Update perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

Co-authored-by: Kotaro Uetake <[email protected]>

* Update perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

Co-authored-by: Kotaro Uetake <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Co-authored-by: Shumpei Wakabayashi <[email protected]>
Co-authored-by: Kotaro Uetake <[email protected]>
autowarefoundation#8413)

* perf(map_based_prediction): improve world to map transform calculation

1. remove unused transforms
2. make transform loading late as possible

Signed-off-by: Taekjin LEE <[email protected]>

* perf(map_based_prediction): get transform only when it is necessary

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
… using lru cache in convertPathType (autowarefoundation#8461)

feat(autoware_map_based_prediction): speed up map based prediction by using lru cache in convertPathType

Signed-off-by: Yukinari Hisaki <[email protected]>
…d of external_surrounding_crosswalks (autowarefoundation#8467)

Signed-off-by: Yukinari Hisaki <[email protected]>
@technolojin technolojin force-pushed the cherry-pick/map-based-pred-performance branch from 3aa3ba2 to f4554af Compare August 15, 2024 00:58
@technolojin technolojin changed the title perf(autoware_map_based_prediction, autoware_universe_utils) perf(autoware_map_based_prediction, autoware_universe_utils): Improve performance of map_based_prediction Aug 15, 2024
@technolojin technolojin marked this pull request as ready for review August 15, 2024 00:59
@technolojin technolojin changed the title perf(autoware_map_based_prediction, autoware_universe_utils): Improve performance of map_based_prediction perf(autoware_map_based_prediction autoware_universe_utils): Improve performance of map_based_prediction Aug 15, 2024
@technolojin technolojin changed the title perf(autoware_map_based_prediction autoware_universe_utils): Improve performance of map_based_prediction perf(autoware_map_based_prediction autoware_universe_utils): improve performance of map_based_prediction Aug 15, 2024
Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully built and launched. LGTM

@technolojin technolojin merged commit ec74077 into tier4:beta/v0.29.0 Aug 15, 2024
22 of 25 checks passed
Copy link

sonarcloud bot commented Aug 15, 2024

@technolojin technolojin deleted the cherry-pick/map-based-pred-performance branch August 15, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants