forked from autowarefoundation/autoware.universe
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(autoware_map_based_prediction autoware_universe_utils): improve performance of map_based_prediction #1464
Merged
technolojin
merged 9 commits into
tier4:beta/v0.29.0
from
technolojin:cherry-pick/map-based-pred-performance
Aug 15, 2024
Merged
perf(autoware_map_based_prediction autoware_universe_utils): improve performance of map_based_prediction #1464
technolojin
merged 9 commits into
tier4:beta/v0.29.0
from
technolojin:cherry-pick/map-based-pred-performance
Aug 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation#8031) fix(autoware_map_based_prediction): fix argument order in call `getFrenetPoint()` Signed-off-by: yucedagonurcan <[email protected]> Co-authored-by: Shintaro Tomie <[email protected]> Co-authored-by: Kotaro Uetake <[email protected]>
…towarefoundation#8403) Signed-off-by: Mamoru Sobue <[email protected]>
…tree query (autowarefoundation#8406) use fence layer Signed-off-by: Mamoru Sobue <[email protected]>
…ndation#8416) perf: apply lerp interpolation instead of spline Signed-off-by: Kotaro Uetake <[email protected]>
…and resample converted path (autowarefoundation#8427) * refactor: improve orientation calculation and resample converted path with linear interpolation Simplify the calculation of the orientation for each pose in the convertPathType function by directly calculating the sine and cosine of half the yaw angle. This improves efficiency and readability. Also, improve the resampling of the converted path by using linear interpolation for better performance. Signed-off-by: Taekjin LEE <[email protected]> * Update perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp Co-authored-by: Kotaro Uetake <[email protected]> * Update perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp Co-authored-by: Kotaro Uetake <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: Shumpei Wakabayashi <[email protected]> Co-authored-by: Kotaro Uetake <[email protected]>
autowarefoundation#8413) * perf(map_based_prediction): improve world to map transform calculation 1. remove unused transforms 2. make transform loading late as possible Signed-off-by: Taekjin LEE <[email protected]> * perf(map_based_prediction): get transform only when it is necessary Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Yukinari Hisaki <[email protected]>
… using lru cache in convertPathType (autowarefoundation#8461) feat(autoware_map_based_prediction): speed up map based prediction by using lru cache in convertPathType Signed-off-by: Yukinari Hisaki <[email protected]>
…d of external_surrounding_crosswalks (autowarefoundation#8467) Signed-off-by: Yukinari Hisaki <[email protected]>
technolojin
force-pushed
the
cherry-pick/map-based-pred-performance
branch
from
August 15, 2024 00:58
3aa3ba2
to
f4554af
Compare
technolojin
changed the title
perf(autoware_map_based_prediction, autoware_universe_utils)
perf(autoware_map_based_prediction, autoware_universe_utils): Improve performance of map_based_prediction
Aug 15, 2024
technolojin
requested review from
ktro2828,
kyoichi-sugahara,
takayuki5168,
tkimura4,
YoshiRi,
soblin and
TakaHoribe
as code owners
August 15, 2024 00:59
technolojin
changed the title
perf(autoware_map_based_prediction, autoware_universe_utils): Improve performance of map_based_prediction
perf(autoware_map_based_prediction autoware_universe_utils): Improve performance of map_based_prediction
Aug 15, 2024
technolojin
changed the title
perf(autoware_map_based_prediction autoware_universe_utils): Improve performance of map_based_prediction
perf(autoware_map_based_prediction autoware_universe_utils): improve performance of map_based_prediction
Aug 15, 2024
YoshiRi
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully built and launched. LGTM
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve performance of map_based_prediction.
autoware_map_based_prediction
fix(autoware_map_based_prediction): fix argument order autowarefoundation/autoware.universe#8031
perf(map_based_prediction): remove unncessary withinRoadLanelet() autowarefoundation/autoware.universe#8403
perf(map_based_prediction): create a fence LineString layer and use rtree query autowarefoundation/autoware.universe#8406
perf(map_based_prediction): apply lerp instead of spline autowarefoundation/autoware.universe#8416
perf(autoware_map_based_prediction): improve orientation calculation and resample converted path autowarefoundation/autoware.universe#8427
perf(map_based_prediction): improve world to map transform calculation autowarefoundation/autoware.universe#8413
perf(autoware_map_based_prediction): speed up map based prediction by using lru cache in convertPathType autowarefoundation/autoware.universe#8461
fix(autoware_map_based_prediction): use surrounding_crosswalks instead of external_surrounding_crosswalks autowarefoundation/autoware.universe#8467
autoware_universe_utils
feat(autoware_universe_utils): add LRU Cache autowarefoundation/autoware.universe#8456
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.