Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: feat(global_parameter_loader): add gtest to global parameter loader (backport #6872) (backport #1274) #1275

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Apr 25, 2024

Description

下記コミットをrevertする
dfec62a

理由は以下の通り

  • 明示的にsample_vehicle_descriptionがdependに設定されているが、sample packageに依存するのは良くないため
  • gtest自体はそこまで重要なテストではないため

Related links

https://star4.slack.com/archives/C03QU7K50D8/p1714022756814529

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.


This is an automatic backport of pull request #1274 done by [Mergify](https://mergify.com).

…loader (backport autowarefoundation#6872) (#1274)

revert: feat(global_parameter_loader): add gtest to global parameter loader (autowarefoundation#6872)

Revert "feat(global_parameter_loader): add gtest to global parameter loader (…"

This reverts commit dfec62a.

(cherry picked from commit e5196bc)
@tkimura4 tkimura4 merged commit 225f8e8 into tier4/main Apr 25, 2024
27 of 28 checks passed
@tkimura4 tkimura4 deleted the mergify/bp/tier4/main/pr-1274 branch April 25, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants