Free scales for coord_polar()
#5354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this tangentially related enough to the milestone for inclusion? |
|
Might be nice, but should double check if this holds for |
Merge branch 'main' into free_polar # Conflicts: # tests/testthat/test-coord-polar.R
|
Yeah lets include this in the milestone, why not? |
|
is it ready for review? |
|
Yes, I'll request it |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #2815.
Briefly, it implements the suggestion to have
CoordPolar$is_free()returnTRUE.To deal with the aspect ratio, the requirement for fixed scales to have
Coords affect the aspect ratio is dropped. I have so far failed to come up with examples where this may lead to awkward situations, so I hope I'm avoiding Chesterton's Fence here. This requirement was originally implemented in cd11888, butcoord_equal()'s behaviour appears unaffected by this PR.Also, a complication arose in #2815 (comment). With this PR,
coord_equal()can also have free scales infacet_grid(), but these are of course locked to the column for x-axes and to the rows for y-axes (see also #1344 and #1152, which might be a topic revisiting separately from this PR). Becausethetacan be either axis, it has no special relation with either horizontal or vertical directions, which makes this a bit awkward.