Full qualification, for dplyr

tidyverse · Mar 8, 2024 · 5c9cca1 · 5c9cca1
1 parent ba115ce
commit 5c9cca1
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/NAMESPACE b/NAMESPACE
@@ -347,7 +347,6 @@ importFrom(tibble,is_tibble)
 importFrom(tibble,new_tibble)
 importFrom(tibble,tibble)
 importFrom(tidyselect,everything)
-importFrom(utils,globalVariables)
 importFrom(utils,head)
 importFrom(vctrs,new_data_frame)
 importFrom(vctrs,new_list_of)

diff --git a/R/distinct.R b/R/distinct.R
@@ -1,5 +1,5 @@
 # Generated by 02-duckplyr_df-methods.R
-globalVariables("___row_number_by")
+utils::globalVariables("___row_number_by")
 
 #' @export
 distinct.duckplyr_df <- function(.data, ..., .keep_all = FALSE) {

diff --git a/R/duckplyr-package.R b/R/duckplyr-package.R
@@ -6,6 +6,7 @@
 # https://github.com/tidyverse/dplyr/blob/16b472fb2afc50a87502c2b4ed803e2f5f82b9d6/R/dplyr.R#L7
 #
 # Can't use blanket cli import, imports must align with dplyr's imports
+# (except we can import all of dplyr)
 #
 #' @import rlang
 ## usethis namespace: start
@@ -27,7 +28,6 @@
 #' @importFrom tibble new_tibble
 #' @importFrom tibble tibble
 #' @importFrom tidyselect everything
-#' @importFrom utils globalVariables
 #' @importFrom utils head
 #' @importFrom vctrs new_data_frame
 #' @importFrom vctrs new_list_of

diff --git a/R/summarise.R b/R/summarise.R
@@ -1,5 +1,5 @@
 # Generated by 02-duckplyr_df-methods.R
-globalVariables("___row_number")
+utils::globalVariables("___row_number")
 
 #' @export
 summarise.duckplyr_df <- function(.data, ..., .by = NULL, .groups = NULL) {