Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved creating index controller from generation to template #815

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Moved creating index controller from generation to template #815

wants to merge 1 commit into from

Conversation

bert-w
Copy link

@bert-w bert-w commented Feb 7, 2017

https://jira.appcelerator.org/browse/AC-4777

Solution shouldnt be much more than this

@feons
Copy link
Contributor

feons commented Mar 15, 2017

@Bertuzb, I think this breaks existing apps that startup from index.

@bert-w
Copy link
Author

bert-w commented Mar 16, 2017

yes when they update it breaks, but this is a much better solution instead of appending unknown code during the compilation process.

Fixing it for any app will be really simple though, simply append Alloy.createController('index') as the last line on alloy.js and you're good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants