Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove old code, fix sdk version, update action #1421

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

remove old code, fix sdk version, update action #1421

wants to merge 3 commits into from

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Oct 1, 2024

  • update github action
  • remove <= Ti 10 if cases
  • remove ti config selected.sdk check (not used anymore)
  • add ti sdk version to the test tiapp.xml file
  • use 12.5.0 in the github action so it will work with the test

@m1ga m1ga mentioned this pull request Oct 1, 2024
Open
@m1ga m1ga requested a review from cb1kenobi October 1, 2024 19:52
cb1kenobi
cb1kenobi requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this PR! Needs a couple of small changes.

What's up with the removal of Ti.UI.iPhone.NavigationGroup.js? Is this a breaking change?

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/publish.yml Outdated Show resolved Hide resolved
test/projects/HarnessTemplate/tiapp.xml Outdated Show resolved Hide resolved
@m1ga
Copy link
Contributor Author

m1ga commented Oct 5, 2024

I love this PR! Needs a couple of small changes.

What's up with the removal of Ti.UI.iPhone.NavigationGroup.js? Is this a breaking change?

DEPRECATED_VERSION = '3.1.3' ...Use Ti.UI.NavigationWindow instead..
Think it has been a long time to keep it around :-)

@cb1kenobi
Copy link
Contributor

The tests fail on WSL for the same reason the CI checks fail below. For example:

alloy compile widgets/wpath/ [ios] compiles without critical error
  Expected { code : 1, killed : false, signal : null, cmd : 'alloy compile /home/chris/projects/titanium/alloy/test/projects/Harness --config platform=ios' } to be falsy.

Not sure what's causing that. Isn't the Android and iOS stuff mocked?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1ga @cb1kenobi