Add new "govulncheck-with-excludes.sh" wrapper script #129
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to exclude GO-2023-1840 (aka CVE-2023-29403; #128 (comment)) from our report since we already refuse to operate when users have enabled the
setuid
bit on the binary.Additionally, this updates our in-code check for
setuid
to also disallowsetgid
, but the impact of that configuration is lesser (so this is considered a best-effort pre-emptive mitigation -- hopefully the block onsetuid
has already discouraged users from usinggosu
in this way).(This is essentially a workaround for golang/go#59507, which isn't ideal, but it's the best we have for now.)