NetworkPkg/HttpBootDxe: Report download error when resume attempts fail #6227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When all resume attempts to continue an interrupted NBP file download have failed, report the failure status to the caller. Original implementation was returning success when number of retries reaches the limit defined by PcdMaxHttpResumeRetries. Signed-off-by: Leandro Gustavo Biss Becker <[email protected]>
tianocore-assign-reviewers
bot
requested review from
ajfish,
leiflindholm,
mdkinney,
SaloniKasbekar and
Zclarkwilliams
|
Hi @SaloniKasbekar, |
SaloniKasbekar
approved these changes
Oct 14, 2024
mdkinney
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report download error status to the caller when all HTTP resume attempts fail.
Description
When all HTTP resume attempts to continue an interrupted NBP file download have failed, report the failure status to the caller.
Original implementation was returning success when number of retries reaches the limit defined by PcdMaxHttpResumeRetries.
How This Was Tested
Configure the UEFI HTTP Boot feature to download a .ISO file. During the file download, remove the uplink cable from your network switch and wait for download error.
Integration Instructions
N/A