Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintainers: Remove Ard Biesheuvel from all packages #6206

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

ardbiesheuvel
Copy link
Member

As a Tianocore maintainer, I am responsible for the packages that I maintain, and am therefore expected to respond in a timely manner to pull requests affecting those packages. With the updated GitHub-based workflow, this now results in daily GitHub spam inviting me to respond to each PR as they are created by the respective authors.

However, I strongly feel that with responsibility, delegated authority should come as well, and this has been stripped away over the past couple of years. When other maintainers fail to respond (which has become more common recently), or when there are glitches in the CI, I no longer have any means to take charge and correct the situation.

The upshot is that I am struggling to do my work as a maintainer, spending 90% of my time dealing with GitHub CI technicalities, or being blocked on other work that is completely ignored by the other maintainers.

This is a waste of my time, and therefore, of my employer's money, so I feel I can no longer justify my involvement. I am therefore stepping down as a maintainer.

As a Tianocore maintainer, I am responsible for the packages that I
maintain, and am therefore expected to respond in a timely manner to
pull requests affecting those packages. With the updated GitHub-based
workflow, this now results in daily GitHub spam inviting me to respond
to each PR as they are created by the respective authors.

However, I strongly feel that with responsibility should come with
delegated authority as well, and this has been stripped away over the
past couple of years. When other maintainers fail to respond (which has
become more common recently), or when there are glitches in the CI, I no
longer have any means to take charge and correct the situation.

The upshot is that I am struggling to do my work as a maintainer,
spending 90% of my time dealing with GitHub CI technicalities, or being
blocked on other work that is completely ignored by the other
maintainers.

This is a waste of my time, and therefore, of my employer's money, so I
feel I can no longer justify my involvement. I am therefore stepping
down as a maintainer.

Signed-off-by: Ard Biesheuvel <[email protected]>
@ardbiesheuvel
Copy link
Member Author

@ardbiesheuvel
Copy link
Member Author

cc @kraxel

Copy link
Member

@leiflindholm leiflindholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While obviously sorry to hear this, I fully understand.
Thank you for all your contributions over the years.

@samimujawar this obviously leaves a pretty big gap on the Arm side, and it leaves ArmVirtPkg completely without maintainers. Could you have a chat internally about how to address this?

@ardbiesheuvel
Copy link
Member Author

cc @lgao4

@kraxel
Copy link
Member

kraxel commented Sep 16, 2024

While obviously sorry to hear this, I fully understand. Thank you for all your contributions over the years.

You will be missed.

@samimujawar this obviously leaves a pretty big gap on the Arm side, and it leaves ArmVirtPkg completely without maintainers. Could you have a chat internally about how to address this?

Leaves a gap for OvmfPkg too, with the most active maintainer leaving.
@jyao1

@os-d
Copy link
Contributor

os-d commented Sep 16, 2024

Oof, definitely a big loss. I’m sorry to hear it, but I understand your frustrations. You were definitely the most active maintainer with thoughtful and insightful feedback, as well as major code contributions. Let us know if we can help drive some change that would encourage you to come back. Best of luck.

@ardbiesheuvel
Copy link
Member Author

Thanks all for the kind words.

You were definitely the most active maintainer with thoughtful and insightful feedback, as well as major code contributions. Let us know if we can help drive some change that would encourage you to come back.

The only thing I ever asked for several times, and was denied each time, is the ability for maintainers to override the CI. Without that, the CI's decision takes precedence over that of human maintainers, turning it into a super maintainer with more control over the project than the actual contributors.

I'll gladly reconsider if that gets resolved.

@samimujawar
Copy link
Contributor

Ard’s been immensely valuable contributor to the Tinacore projects over the years. His unique experience of working on kernel development, security and other firmware projects has meant the Tinacore project support for the Arm ecosystem is a much better place than it would have been. Whilst, respecting Ard’s personal decision, his withdrawal leaves gaps that is not possible to solve in the short to medium. Personally, I am disappointed and frustrated it’s got to a point a willing key maintainer is not able to be productive and carry out their day-to-day maintainership due to the limitations of the CI and workflow. Why can’t these issue be taken more seriously and addressed? Let’s listen to Ard’s concerns and try to fix these issues as any replacement coming through is also likely face the same set of problems. I am willing to take on additional maintainer/reviewer responsibility in a gradual manner, but I would really like the community to help address Ard’s concerns and look at what can be done to fix that first.

@leiflindholm
Copy link
Member

@samimujawar

Why can’t these issue be taken more seriously and addressed?

For the usual reason: resources.
Is Arm willing to commit resources for the substantial effort required to 1) keep a CI system running and 2) implement the changes required for the system to not get in the way?

That's probably not a topic for a PR though.

@mdkinney
Copy link
Member

I agree that the concerns about CI and a discussion of possible solutions can be moved to a different location.

One option is the GitHub discussion has been started for the CI/Tools meeting on Sept 30.

There are links in there to additional discussions for CI improvement ideas and the transition to GitHub issues.

Another option is a thread on [email protected]

@ardbiesheuvel ardbiesheuvel added the push Auto push patch series in PR if all checks pass label Sep 17, 2024
@mergify mergify bot merged commit 7796422 into tianocore:master Sep 17, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants