Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicTablesPkg: Adds ACPI HPET table generator #6161

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

abdattar
Copy link
Contributor

@abdattar abdattar commented Sep 4, 2024

Adds X64 ACPI HPET table generator library.
Updates acpi standard table enum with hpet.
Updates X64 namespace object.
Updates the object parser.
Updates the Readme.

Cc: Sami Mujawar [email protected]
Cc: Pierre Gondois [email protected]

Description

Changes to generate ACPI HPET table for X64 based platforms

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Tested with downstream on AMD X64 platform.

Integration Instructions

N/A

@abdattar
Copy link
Contributor Author

abdattar commented Sep 4, 2024

Attaching "acpiview -S HPET" command output.
hpet.txt

Abdul Lateef Attar added 2 commits September 6, 2024 05:44
Adds X64 ACPI HPET table generator library.
Updates acpi standard table enum with hpet.
Updates X64 namespace object.
Updates the object parser.
Updates the Readme.

Cc: Sami Mujawar <[email protected]>
Cc: Pierre Gondois <[email protected]>
Signed-off-by: Abdul Lateef Attar <[email protected]>
Adds X64 ACPI SSDT HPET table generator library.
Updates acpi standard table enum with hpet.
Generate ACPI HPET device as per specification.

Cc: Sami Mujawar <[email protected]>
Cc: Pierre Gondois <[email protected]>
Signed-off-by: Abdul Lateef Attar <[email protected]>
@abdattar
Copy link
Contributor Author

abdattar commented Sep 6, 2024

Added the patch for SSDT HPET creation also.

@abdattar
Copy link
Contributor Author

Hi @AbnerChang, @samimujawar, @pierregondois,
Gentle reminder; please review the patch.
Thanks
AbduL

Copy link
Contributor

@samimujawar samimujawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These patches look good to me.

@samimujawar
Copy link
Contributor

@AbnerChang can you review this series and provide your feedback, please?
I will then apply the push label.

Copy link
Member

@changab changab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the maintainer or reviewer, but Acked-by.

@samimujawar samimujawar added the push Auto push patch series in PR if all checks pass label Sep 18, 2024
@mergify mergify bot merged commit 5901f19 into tianocore:master Sep 18, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants