OvmfPkg/ResetVector: Move condition end outside of SearchBfv #6154
Conversation
The %endif for %ifdef ARCH64 was originally inside SearchBvf, which makes the code harder to read and obscures the necessity of having it within SearchBvf. To improve code readability, move the condition end outside of SearchBvf. Signed-off-by: Richard Lyu <[email protected]>
tianocore-assign-reviewers
bot
requested review from
ardbiesheuvel,
jyao1,
kraxel,
mdroth,
mxu9,
ruleof2 and
tlendacky
|
Thanks for taking the time to submit this, but I don't think this is something that needs fixing as I don't think there is anything wrong with the code as-is. |
|
Thank you, @ardbiesheuvel. Although it does not affect the execution of the program, I believe that the modified version makes it easier for someone to understand this section of the code. The %endif condition doesn't actually need to be written within SearchBvf. This approach will also make it easier for others to maintain the code in the future. However, if you believe that is not necessary, please feel free to disregard this PR. |
|
I'd argue that, given that the label is only references inside the %if block, it should be defined inside the %if block as well. |
|
Thank you for your suggestion. I have no issues with this part now. |
The %endif for %ifdef ARCH64 was originally inside SearchBvf, which makes the code harder to read and obscures the necessity of having it within SearchBvf. To improve code readability, move the condition end outside of SearchBvf.