MdePkg,ShellPkg: Add New Socket Type for SMBIOS Type4 #6115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
lgao4,
LiuZhiguang001,
mdkinney and
ZhichaoGao
jiahuanzhao
force-pushed
the
Smbios_3_8_update
branch
2 times, most recently
from
cb7a879
to
60e04a1
Compare
LiuZhiguang001
approved these changes
Aug 28, 2024
ChandanaKumarC
approved these changes
Aug 28, 2024
|
The code change is good. But, the commit message is not incosistent. One is Add New, another is add new. I suggest to use Add new. |
jiahuanzhao
force-pushed
the
Smbios_3_8_update
branch
from
60e04a1
to
5f78b9f
Compare
Thanks for the comments, updated commit message! |
tianocore-assign-reviewers
bot
requested review from
ajfish and
leiflindholm
jiahuanzhao
force-pushed
the
Smbios_3_8_update
branch
from
5f78b9f
to
eaeba19
Compare
lgao4
approved these changes
Sep 3, 2024
jiahuanzhao
force-pushed
the
Smbios_3_8_update
branch
3 times, most recently
from
2b75c50
to
0806d55
Compare
The patch adds new socket type(Type 4, Offset 32h) for SMBIOS Type4 based on SMBIOS v3.8.0. Signed-off-by: Jason Zhao <[email protected]>
The patch adds ProcessorUpgradeInvalid(0xFF) definition in Processor Upgrade(Type 4, Offset 19h) for SMBIOS Type4 based on SMBIOS v3.8.0. Processor Upgrade should be 0xFF when no other valid enumeration is available. Signed-off-by: Jason Zhao <[email protected]>
The patch prints new socket type(Type 4, Offset 32h) for SMBIOS Type4 based on SMBIOS v3.8.0. Signed-off-by: Jason Zhao <[email protected]>
jiahuanzhao
force-pushed
the
Smbios_3_8_update
branch
from
0806d55
to
7d00a36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch adds new socket type (Type 4, Offset 32h) for SMBIOS Type4 and also update SmbiosView PrintInfo.c to use the new field name based on SMBIOS v3.8.0.