-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShellPkg: Add support to parse SPMI table in acpiview #5980
base: master
Are you sure you want to change the base?
Conversation
3af1815
to
67104c6
Compare
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818 Added support for acpiview shell utility to parse and print SPMI table Cc: Abdul Lateef Attar <[email protected]> Cc: Abner Chang <[email protected]> Cc: Paul Grimes <[email protected]> Cc: Zhichao Gao <[email protected]> Signed-off-by: Shankar C <[email protected]>
Shankar, you need to add Signed-off-by: your name . |
hi, i added in the commit but it did not reflect in the description. ill just edit the description |
Could you attach the dump result for SPMI table? |
@shkrc can you paste the acpiview -S SPMI output ? |
spmi.log |
Hi @lgao4 can you help review this patch? |
Hi @ZhichaoGao could you please merge the changes. |
could you please push the code changes? |
PR can not be merged due to conflict. Please rebase and resubmit |
{ L"PCI Device Flag", 1, 43, L"0x%x", NULL, NULL, NULL, NULL }, | ||
{ L"Global System Interrupt", 4, 44, L"0x%x", NULL, NULL, NULL, NULL }, | ||
{ L"Base Address", 12, 48, NULL, DumpGas, NULL, NULL, NULL }, | ||
{ L"PCI Segment Group No. / UID Byte 1",1, 60, L"0x%x", NULL, NULL, NULL, NULL }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This format looks weird to me, was this done by the Uncrustify?
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818
Added support for acpiview shell utility to parse and print SPMI table
Cc: Abdul Lateef Attar [email protected]
Cc: Abner Chang [email protected]
Cc: Paul Grimes [email protected]
Cc: Zhichao Gao [email protected]
Signed-off-by: Shankar C [email protected]
Description
<Include a description of the change and why this change was made.>
<For each item, place an "x" in between
[
and]
if true. Example:[x]
(you can also check items in GitHub UI)><Create the PR as a Draft PR if it is only created to run CI checks.>
<Delete lines in <> tags before creating the PR.>
How This Was Tested
<Describe the test(s) that were run to verify the changes.>
Integration Instructions
<Describe how these changes should be integrated. Use N/A if nothing is required.>