Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShellPkg: Add support to parse SPMI table in acpiview #5980

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shkrc
Copy link

@shkrc shkrc commented Jul 26, 2024

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818

Added support for acpiview shell utility to parse and print SPMI table

Cc: Abdul Lateef Attar [email protected]
Cc: Abner Chang [email protected]
Cc: Paul Grimes [email protected]
Cc: Zhichao Gao [email protected]
Signed-off-by: Shankar C [email protected]

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

@shkrc shkrc force-pushed the acpiview-spmi branch 2 times, most recently from 3af1815 to 67104c6 Compare July 26, 2024 04:44
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818

Added support for acpiview shell utility to parse and print SPMI table

Cc: Abdul Lateef Attar <[email protected]>
Cc: Abner Chang <[email protected]>
Cc: Paul Grimes <[email protected]>
Cc: Zhichao Gao <[email protected]>
Signed-off-by: Shankar C <[email protected]>
@abdattar
Copy link
Contributor

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818

Added support for acpiview shell utility to parse and print SPMI table

Cc: Abdul Lateef Attar [email protected] Cc: Abner Chang [email protected] Cc: Paul Grimes [email protected]

Shankar, you need to add Signed-off-by: your name .
Also need to Cc maintainers.
Cc: Zhichao Gao [email protected]

@shkrc
Copy link
Author

shkrc commented Jul 29, 2024

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4818
Added support for acpiview shell utility to parse and print SPMI table
Cc: Abdul Lateef Attar [email protected] Cc: Abner Chang [email protected] Cc: Paul Grimes [email protected]

Shankar, you need to add Signed-off-by: your name . Also need to Cc maintainers. Cc: Zhichao Gao [email protected]

hi, i added in the commit but it did not reflect in the description. ill just edit the description

@lgao4
Copy link
Contributor

lgao4 commented Jul 30, 2024

Could you attach the dump result for SPMI table?

@abdattar
Copy link
Contributor

abdattar commented Aug 2, 2024

@shkrc can you paste the acpiview -S SPMI output ?

@shkrc
Copy link
Author

shkrc commented Aug 2, 2024

spmi.log
I have attached the log here

@shkrc
Copy link
Author

shkrc commented Aug 13, 2024

Hi @lgao4 can you help review this patch?

@abdattar
Copy link
Contributor

abdattar commented Sep 1, 2024

Hi @ZhichaoGao could you please merge the changes.

@abdattar
Copy link
Contributor

could you please push the code changes?

Copy link

mergify bot commented Sep 17, 2024

PR can not be merged due to conflict. Please rebase and resubmit

{ L"PCI Device Flag", 1, 43, L"0x%x", NULL, NULL, NULL, NULL },
{ L"Global System Interrupt", 4, 44, L"0x%x", NULL, NULL, NULL, NULL },
{ L"Base Address", 12, 48, NULL, DumpGas, NULL, NULL, NULL },
{ L"PCI Segment Group No. / UID Byte 1",1, 60, L"0x%x", NULL, NULL, NULL, NULL },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This format looks weird to me, was this done by the Uncrustify?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants