Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UefiCpuPkg/MpInitLib: Reduce compiler dependencies for LoongArch #5960

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

MarsDoge
Copy link
Member

@MarsDoge MarsDoge commented Jul 24, 2024

Structure assignment may depend on the compiler to expand to memcpy.
For this, we may need to add -mno-memcpy to the compilation flag.
Here, we reduce dependencies and use CopyMem for data conversion without
memcpy.

Cc: Ray Ni [email protected]
Cc: Rahul Kumar [email protected]
Cc: Gerd Hoffmann [email protected]
Cc: Jiaxin Wu [email protected]
Cc: Chao Li [email protected]
Signed-off-by: Dongyan Qian [email protected]
Co-authored-by: Chao Li [email protected]

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

@MarsDoge MarsDoge marked this pull request as draft July 24, 2024 07:18
@MarsDoge MarsDoge marked this pull request as ready for review July 24, 2024 07:21
@kilaterlee kilaterlee added push Auto push patch series in PR if all checks pass and removed push Auto push patch series in PR if all checks pass labels Jul 25, 2024
Structure assignment may depend on the compiler to expand to memcpy.
For this, we may need to add -mno-memcpy to the compilation flag.
Here, we reduce dependencies and use CopyMem for data conversion without
memcpy.

Cc: Ray Ni <[email protected]>
Cc: Rahul Kumar <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jiaxin Wu <[email protected]>
Cc: Chao Li <[email protected]>
Signed-off-by: Dongyan Qian <[email protected]>
Co-authored-by: Chao Li <[email protected]>
@kilaterlee kilaterlee added the push Auto push patch series in PR if all checks pass label Jul 25, 2024
@mergify mergify bot merged commit 556640b into tianocore:master Jul 25, 2024
128 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants