MdeModulePkg: Enable VarCheckHiiLibStandaloneMm #5938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xieyuanh
changed the title
xieyuanh
changed the title
xieyuanh
force-pushed
the
VarFinal
branch
2 times, most recently
from
db3856b
to
2438b1d
Compare
xuweiintel
reviewed
Jul 25, 2024
MdeModulePkg/Library/VarCheckHiiLib/VarCheckHiiLibStandaloneMm.inf
Outdated
Show resolved
Hide resolved
xieyuanh
changed the title
jiaxinwu
approved these changes
Aug 16, 2024
jiaxinwu
approved these changes
Aug 16, 2024
github-actions
bot
added
the
impact:security
xuweiintel
approved these changes
Aug 23, 2024
github-actions
bot
added
the
impact:testing
dandanbi
approved these changes
Aug 23, 2024
lgao4
reviewed
Aug 30, 2024
|
I agree this change. I only have one minor comment. Please check. |
tianocore-assign-reviewers
bot
requested review from
LiuZhiguang001 and
mdkinney
lgao4
approved these changes
Sep 2, 2024
Relocate the declaration of mVarCheckHiiBin to support for standalone MM modules utilizing the same mVarCheckHiiBin. Cc: Liming Gao <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Star Zeng <[email protected]> Cc: Hongbin1 Zhang <[email protected]> Cc: Wei6 Xu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Dandan Bi <[email protected]> Signed-off-by: Yuanhao Xie <[email protected]>
VarCheckHiiLibMmDependency retrieve data (mVarCheckHiiBin) at the end of the DXE phase, and pass the acquired data to the VarCheckHiiLibStandaloneMm through a communication protocol. Cc: Liming Gao <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Star Zeng <[email protected]> Cc: Hongbin1 Zhang <[email protected]> Cc: Wei6 Xu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Dandan Bi <[email protected]> Signed-off-by: Yuanhao Xie <[email protected]>
Cc: Liming Gao <[email protected]> Cc: Jiaxin Wu <[email protected]> Cc: Ray Ni <[email protected]> Signed-off-by: Yuanhao Xie <[email protected]>
Change the Size parameter of BuildVarCheckHiiBin from OUT to an input-output parameter. Cc: Liming Gao <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Star Zeng <[email protected]> Cc: Hongbin1 Zhang <[email protected]> Cc: Wei6 Xu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Dandan Bi <[email protected]> Signed-off-by: Yuanhao Xie <[email protected]>
No functional changes. Cc: Liming Gao <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Star Zeng <[email protected]> Cc: Hongbin1 Zhang <[email protected]> Cc: Wei6 Xu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Dandan Bi <[email protected]> Signed-off-by: Yuanhao Xie <[email protected]>
Rename SetVariableCheckHandlerHii and wrap it as a common API to facilitate the usage in the following patches. Cc: Liming Gao <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Star Zeng <[email protected]> Cc: Hongbin1 Zhang <[email protected]> Cc: Wei6 Xu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Dandan Bi <[email protected]> Signed-off-by: Yuanhao Xie <[email protected]>
Move VarCheckHiiInternalDumpHex and VarCheckHiiQuestion to the common file. Cc: Liming Gao <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Star Zeng <[email protected]> Cc: Hongbin1 Zhang <[email protected]> Cc: Wei6 Xu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Dandan Bi <[email protected]> Signed-off-by: Yuanhao Xie <[email protected]>
No functional changes. Move DUMP_VAR_CHECK_HII in common file Cc: Liming Gao <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Star Zeng <[email protected]> Cc: Hongbin1 Zhang <[email protected]> Cc: Wei6 Xu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Dandan Bi <[email protected]> Signed-off-by: Yuanhao Xie <[email protected]>
This library is designed for handling variable HII checks within the Standalone MMm environment. It includes the functions dedicated to registering handlers that process information received from VarCheckHiiLibMmDependency. Cc: Liming Gao <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Star Zeng <[email protected]> Cc: Hongbin1 Zhang <[email protected]> Cc: Wei6 Xu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Dandan Bi <[email protected]> Signed-off-by: Yuanhao Xie <[email protected]>
Enable VarCheckHiiLibStandaloneMm. Cc: Liming Gao <[email protected]> Cc: Rahul Kumar <[email protected]> Cc: Gerd Hoffmann <[email protected]> Cc: Star Zeng <[email protected]> Cc: Hongbin1 Zhang <[email protected]> Cc: Wei6 Xu <[email protected]> Cc: Dun Tan <[email protected]> Cc: Dandan Bi <[email protected]> Signed-off-by: Yuanhao Xie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VarCheckHiiLib is a library for handling HII (Human Interface Infrastructure) variable checking tasks in a UEF environment. HII allows firmware to provide user interface elements such as forms, keyboard input, and display text.
This patch series introduces a standalone MM module for managing HII variable checks. It consists of two components:
VarCheckHiiLibMmDependency: Retrieves data (mVarCheckHiiBin) at the end of the DXE phase and transmits it to VarCheckHiiLibStandaloneMm via the communication protocol.
VarCheckHiiLibStandaloneMm: A library within the Standalone MM environment designed to handle HII variable checks. It features functions for registering handlers that process data received from VarCheckHiiLibMmDependency.
Breaking change - Does this PR cause a break in build or boot behavior?
Examples: Does it add a new library class or move a module to a different repo.
Impacts security? - Does this PR have a direct security impact?
Examples: Crypto algorithm change or buffer overflow fix.
Includes tests? - Does this PR include any explicit test code?
Examples: Unit tests or integration tests.
How This Was Tested
The testing on Intel's next-generation server processor platform. It confirms that debug messages are properly printed out with correct attributes, including binary size and GUID. It also verifies that the corresponding SMI handler is registered and operates successfully.
Integration Instructions
N/A