Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdeModulePkg: Optimize PEI Core Migration Algorithm #5875

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

awiralsh
Copy link
Contributor

@awiralsh awiralsh commented Jul 5, 2024

Description

Migrate the FV that doesn't contain the currently executing PEI Core when memory is initialized but PEI Core is still potentially running from faster memory. This may reduce the time required to migrate FVs to permanent memory. The FV containing PEI Core is migrated after the PEI Core reentry when it is executed from permanent memory.
This migration algorithm is only used for FVs specified in the gEdkiiMigrationInfoGuid HOB.

How This Was Tested

Tested by tianocore edk2 CI

@lgao4 lgao4 requested review from lgao4 and mdkinney July 5, 2024 10:28
@lgao4
Copy link
Contributor

lgao4 commented Jul 23, 2024

Have you collected the performance data with this change?

@awiralsh awiralsh force-pushed the Optimize_Migration_Algorithm branch 3 times, most recently from 99bf4f3 to b9070cc Compare July 25, 2024 14:14
@awiralsh
Copy link
Contributor Author

Have you collected the performance data with this change?

This may or may not improve performance depending on the behavior of temporary RAM and the actual performance changes must be measured with the feature enabled and disabled.

@lgao4
Copy link
Contributor

lgao4 commented Jul 26, 2024

Have you collected the performance data with this change?

This may or may not improve performance depending on the behavior of temporary RAM and the actual performance changes must be measured with the feature enabled and disabled.

I understand this change will improve the performance on the specific condition. Right?

@awiralsh
Copy link
Contributor Author

Have you collected the performance data with this change?

This may or may not improve performance depending on the behavior of temporary RAM and the actual performance changes must be measured with the feature enabled and disabled.

I understand this change will improve the performance on the specific condition. Right?

Yes, If the Temporary memory is faster than the permanent memory, this change improves the performance.

@lgao4 lgao4 added the push Auto push patch series in PR if all checks pass label Jul 30, 2024
REF : https://bugzilla.tianocore.org/show_bug.cgi?id=4750

Migrate the FV that doesn't contain the currently executing PEI Core
when permanent memory is initialized but PEI Core is still potentially
running from faster memory (Tepmorary RAM). This may reduce the time
required to migrate FVs to permanent memory. The FV containing PEI
Core is migrated after the PEI Core reentry when it is executed from
permanent memory.

This may or may not improve performance depending on the behavior of
temporary RAM and the actual performance changes must be measured with
the feature enabled and disabled.

This migration algorithm is only used for FVs specified in the
gEdkiiMigrationInfoGuid HOB and built with flag
FLAGS_FV_MIGRATE_BEFORE_PEI_CORE_REENTRY.

Signed-off-by: Awiral Shrivastava <[email protected]>
@lgao4 lgao4 force-pushed the Optimize_Migration_Algorithm branch from b9070cc to bf6a551 Compare July 30, 2024 05:05
@mergify mergify bot merged commit 5b08df0 into tianocore:master Jul 30, 2024
126 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants