NetworkPkg/HttpBootDxe: Report download error when resume attempts fail

When all resume attempts to continue an interrupted NBP file download have failed, report the failure status to the caller. Original implementation was returning success when number of retries reaches the limit defined by PcdMaxHttpResumeRetries. Signed-off-by: Leandro Gustavo Biss Becker <[email protected]>
tianocore · Sep 20, 2024 · 7919f81 · 7919f81
1 parent 222e285
commit 7919f81
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/NetworkPkg/HttpBootDxe/HttpBootImpl.c b/NetworkPkg/HttpBootDxe/HttpBootImpl.c
@@ -388,7 +388,8 @@ HttpBootGetBootFileCaller (
                      ImageType
                      );
           if (!EFI_ERROR (Status) ||
-              ((Status != EFI_TIMEOUT) && (Status != EFI_DEVICE_ERROR)))
+              ((Status != EFI_TIMEOUT) && (Status != EFI_DEVICE_ERROR)) ||
+              (Retries >= PcdGet32 (PcdMaxHttpResumeRetries)))
           {
             break;
           }