Skip to content

Commit

Permalink
Resolve the conflicts
Browse files Browse the repository at this point in the history
Signed-off-by: JmPotato <[email protected]>
  • Loading branch information
JmPotato committed Jun 25, 2024
1 parent 4946557 commit 32743de
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 79 deletions.
75 changes: 0 additions & 75 deletions pkg/schedule/config/store_config_test.go

This file was deleted.

5 changes: 1 addition & 4 deletions pkg/typeutil/size_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,9 @@ func TestSizeJSON(t *testing.T) {
}

func TestParseMbFromText(t *testing.T) {
<<<<<<< HEAD:pkg/typeutil/size_test.go
t.Parallel()
=======
const defaultValue = 2

>>>>>>> 6fbe73796 (config: fix the panic caused by zero RegionSplitSizeMB (#8324)):pkg/utils/typeutil/size_test.go
t.Parallel()
re := require.New(t)
testCases := []struct {
body []string
Expand Down
6 changes: 6 additions & 0 deletions server/config/store_config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import (

"github.com/docker/go-units"
"github.com/stretchr/testify/require"
"github.com/tikv/pd/pkg/typeutil"
)

func TestTiKVConfig(t *testing.T) {
Expand Down Expand Up @@ -158,4 +159,9 @@ func TestMergeCheck(t *testing.T) {
re.Error(config.CheckRegionKeys(v.keys, v.mergeKeys))
}
}
// Test CheckRegionSize when the region split size is 0.
config.RegionSplitSize = "100KiB"
config.RegionSplitSizeMB = typeutil.ParseMBFromText(config.RegionSplitSize, defaultRegionSplitSize)
re.Empty(config.GetRegionSplitSize())
re.NoError(config.CheckRegionSize(defaultRegionMaxSize, 50))
}

0 comments on commit 32743de

Please sign in to comment.