Skip to content

Commit

Permalink
remove coverage tracking
Browse files Browse the repository at this point in the history
  • Loading branch information
zaibon committed Apr 23, 2020
1 parent 96dff22 commit 42405ac
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 31 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,18 +25,10 @@ jobs:
- name: Run tests
run: |
cd pkg
make coverage
make testrace
env:
GO111MODULE: on

- name: Send coverage
if: success()
run: |
cd pkg
bash <(curl -s https://codecov.io/bash)
env:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

- name: Build binaries
run: |
cd cmds
Expand Down
13 changes: 4 additions & 9 deletions pkg/Makefile
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
PWD := $(shell pwd)
GOPATH := $(shell go env GOPATH)
# LDFLAGS := $(shell go run buildscripts/gen-ldflags.go)

# BUILD_LDFLAGS := '$(LDFLAGS)'

all: build

Expand Down Expand Up @@ -45,7 +42,6 @@ spelling:
static:
go run honnef.co/go/tools/cmd/staticcheck -- ./...

# Builds minio, runs the verifiers then runs the tests.
check: test
test: verifiers build
# we already ran vet separately, so safe to turn it off here
Expand All @@ -55,12 +51,11 @@ test: verifiers build
done

testrace: verifiers build
@echo "Running unit tests with GOFLAGS=${GOFLAGS}"
# we already ran vet separately, so safe to turn it off here
@CGO_ENABLED=1 go test -v -vet=off -race ./...

coverage: verifiers build
@(env bash $(PWD)/buildscripts/go-coverage.sh)
@echo "Running unit tests with GOFLAGS=${GOFLAGS}"
for pkg in $(shell go list ./... | grep -Ev "stubs|network" ); do \
go test -v -vet=off -race $$pkg; \
done

generate:
@echo "Generating modules client stubs"
Expand Down
13 changes: 0 additions & 13 deletions pkg/buildscripts/go-coverage.sh

This file was deleted.

0 comments on commit 42405ac

Please sign in to comment.