[MASWE-0014] Add Cryptographic Keys Not Properly Protected at Rest (O…

…WASP#2781)

* [MASWE-0014] Add Cryptographic Keys Not Properly Protected at Rest

* improve content

* add new test


* Update MASWE-0005 to be API Keys Hardcoded in the App Package

* add new demo

* add new demos files

* include RASP

* add binary and output with simpler function

* update demo 13 with detailed write-up and output files

* update demos to use asm for better output

* remove asm bytes

* rename tests

* Add white-box cryptography technique for encrypting API keys and sensitive data

* fix url

.gitignore

@@ -28,4 +28,5 @@ docs/MASWE
 docs/assets/Images
 OWASP_MASVS.yaml
 cross_references.yaml
+drafts/
 Payload/

demos/ios/MASVS-CRYPTO/MASTG-DEMO-0013/MASTG-DEMO-0013.md

@@ -0,0 +1,30 @@
+---
+platform: ios
+title: Use of Hardcoded RSA Private Key in SecKeyCreateWithData with r2
+code: [swift]
+id: MASTG-DEMO-0013
+test: MASTG-TEST-0213
+---
+
+### Sample
+
+{{ MastgTest.swift # function.asm }}
+
+### Steps
+
+1. Unzip the app package and locate the main binary file (@MASTG-TECH-0058), which in this case is `./Payload/MASTestApp.app/MASTestApp`.
+2. Open the app binary with @MASTG-TOOL-0073 with the `-i` option to run this script.
+
+{{ sec_hardcoded_rsa.r2 }}
+
+{{ run.sh }}
+
+### Observation
+
+The output reveals a call to `SecKeyCreateWithData` as well as the hardcoded RSA private key within the DATA section of the binary.
+
+{{ output.asm # key.asm }}
+
+### Evaluation
+
+The test fails because a hardcoded RSA private key was found in the code.

demos/ios/MASVS-CRYPTO/MASTG-DEMO-0013/MastgTest.swift

@@ -0,0 +1,117 @@
+import Foundation
+import Security
+
+struct MastgTest {
+    static func mastgTest(completion: @escaping (String) -> Void) {
+
+	// Step 1: Use a hardcoded RSA private key (in DER format)
+	let privateKeyBytes: [UInt8] = [
+		0x30, 0x82, 0x02, 0x5b, 0x02, 0x01, 0x00, 0x02, 0x81, 0x81, 0x00, 0xbd, 0xf6, 0x89, 0x8f, 0xbd, 
+		0x0c, 0xe6, 0x4f, 0x9a, 0x97, 0xec, 0x30, 0x1a, 0x48, 0x93, 0x4d, 0x2a, 0xbf, 0xdf, 0xf7, 0x08, 
+		0x15, 0x4c, 0xdb, 0x87, 0xe5, 0xdf, 0xb1, 0xcf, 0x8d, 0xa2, 0x5e, 0x2a, 0x7d, 0x92, 0xa8, 0xbd, 
+		0x30, 0xb9, 0x10, 0xcf, 0x96, 0xda, 0x10, 0x25, 0xd4, 0x67, 0xaf, 0x92, 0x26, 0xfa, 0x43, 0xb7, 
+		0x86, 0x83, 0xa2, 0x68, 0xd4, 0x7a, 0x56, 0xce, 0x41, 0x41, 0xed, 0xc0, 0x10, 0x0c, 0x89, 0xa5, 
+		0x4e, 0x5f, 0xc4, 0x59, 0xcc, 0x55, 0x09, 0x1f, 0xa1, 0x1f, 0x1f, 0xb7, 0x97, 0x1d, 0x53, 0x1b, 
+		0x73, 0x38, 0x4c, 0x3e, 0xe8, 0x28, 0x1d, 0xc1, 0x68, 0x6a, 0x8d, 0x3e, 0xb0, 0xf2, 0x0a, 0xb3, 
+		0x74, 0x26, 0xd2, 0xdc, 0xcf, 0xa4, 0xac, 0xf3, 0x5b, 0x26, 0x35, 0xd1, 0x2d, 0xee, 0x91, 0x41, 
+		0xa6, 0x93, 0xed, 0x91, 0xfa, 0xd7, 0x43, 0x83, 0x85, 0x53, 0xe5, 0x02, 0x03, 0x01, 0x00, 0x01, 
+		0x02, 0x81, 0x80, 0x01, 0xed, 0xbf, 0x79, 0xcd, 0xee, 0x94, 0x32, 0x73, 0x1c, 0x5f, 0x5e, 0x88, 
+		0x0f, 0x62, 0x94, 0x48, 0x98, 0x3b, 0x54, 0x80, 0x8f, 0x1b, 0x9a, 0xdc, 0x9a, 0x91, 0x16, 0xaa, 
+		0x14, 0x9c, 0xa8, 0x6a, 0xe6, 0x6c, 0xb0, 0xf9, 0x7f, 0x92, 0x8b, 0x0d, 0xc0, 0x84, 0x25, 0x13, 
+		0xd3, 0xa6, 0x75, 0xda, 0x16, 0x3a, 0xd3, 0x0f, 0xfc, 0x8f, 0x71, 0xfc, 0x7e, 0x16, 0xfb, 0xe5, 
+		0x71, 0x67, 0xc6, 0x8a, 0x4b, 0xfb, 0x12, 0x13, 0x68, 0x45, 0xd6, 0x17, 0xbd, 0xd2, 0x83, 0x69, 
+		0x17, 0xc8, 0x44, 0x84, 0xb0, 0x25, 0xe4, 0x49, 0x9e, 0x51, 0x95, 0x05, 0x79, 0xe6, 0x86, 0x4a, 
+		0xf6, 0xc4, 0x5e, 0x70, 0x52, 0x18, 0xf0, 0x46, 0x63, 0x42, 0x32, 0x1b, 0x07, 0x52, 0x83, 0xee, 
+		0xd0, 0xbc, 0x0b, 0x6e, 0x12, 0xed, 0x27, 0xbb, 0x03, 0x31, 0xbb, 0xa5, 0x24, 0xc7, 0x2e, 0x3b, 
+		0xd6, 0xe9, 0x25, 0x02, 0x41, 0x00, 0xcb, 0x78, 0x2f, 0x7f, 0x51, 0x2f, 0x49, 0xf0, 0xf8, 0xdb, 
+		0x2f, 0xc3, 0x18, 0xc8, 0x41, 0x62, 0x41, 0x69, 0x4c, 0xc0, 0x78, 0x98, 0x6c, 0xce, 0xdb, 0x86, 
+		0x1e, 0x04, 0x99, 0x11, 0x6c, 0x3d, 0x98, 0x8c, 0xa1, 0xcf, 0xb7, 0x48, 0xa2, 0x8b, 0x53, 0x28, 
+		0x31, 0xfd, 0x15, 0x5f, 0x56, 0xc0, 0xc4, 0xc1, 0xe6, 0x25, 0x8b, 0x69, 0x83, 0xe8, 0x59, 0xd2, 
+		0x2b, 0x3e, 0xe7, 0xc9, 0xbb, 0xfb, 0x02, 0x41, 0x00, 0xef, 0x01, 0xad, 0x4f, 0xdb, 0xa4, 0xb9, 
+		0x59, 0x81, 0x23, 0x5e, 0xd1, 0x10, 0xee, 0x0a, 0xa3, 0x51, 0x24, 0x6f, 0x60, 0x45, 0x5c, 0xd5, 
+		0x70, 0x5c, 0xa4, 0x4a, 0x32, 0x70, 0x56, 0xa2, 0x6f, 0x64, 0xaf, 0x68, 0xc9, 0x70, 0xd8, 0x93, 
+		0x38, 0x86, 0x1a, 0x94, 0xc0, 0xbe, 0xb7, 0xb0, 0x9d, 0x8d, 0xb5, 0x59, 0xf6, 0x3a, 0x3a, 0xed, 
+		0xd7, 0x54, 0x77, 0x57, 0x10, 0x9a, 0xad, 0x49, 0x9f, 0x02, 0x40, 0x6c, 0xf3, 0x95, 0x53, 0x72, 
+		0x90, 0x84, 0xe2, 0x81, 0x0f, 0x35, 0x7b, 0x1d, 0xc9, 0x15, 0xa1, 0xdc, 0x6e, 0xdb, 0x47, 0x71, 
+		0x0c, 0x05, 0xaf, 0x9a, 0xc3, 0x2d, 0x4d, 0xbe, 0xfd, 0x22, 0x5d, 0xb5, 0x53, 0x10, 0xce, 0x5e, 
+		0x51, 0x89, 0xa0, 0x5b, 0x4d, 0xf9, 0xbe, 0x90, 0x74, 0x35, 0xcb, 0x11, 0x50, 0xd6, 0xc1, 0x21, 
+		0xee, 0xc5, 0x50, 0x64, 0xd0, 0x72, 0x91, 0xc3, 0xa2, 0x35, 0x83, 0x02, 0x40, 0x62, 0xee, 0xd6, 
+		0xc6, 0xcf, 0xac, 0x87, 0xec, 0xbc, 0xbf, 0xdf, 0x67, 0xbb, 0x12, 0x4d, 0xe4, 0xfc, 0x99, 0x90, 
+		0x60, 0xd1, 0x55, 0x74, 0x24, 0x66, 0xb4, 0xba, 0xe1, 0xd6, 0x0e, 0x86, 0x7e, 0x85, 0xb6, 0xf6, 
+		0x31, 0x2c, 0x3c, 0xf9, 0xf3, 0xd3, 0xce, 0xfc, 0xf4, 0x2b, 0xfd, 0xed, 0x65, 0xca, 0x5a, 0xdf, 
+		0x3a, 0x45, 0x30, 0x4f, 0x73, 0x6a, 0xcb, 0x5b, 0x86, 0xcc, 0x00, 0x1f, 0x11, 0x02, 0x40, 0x5e, 
+		0x6b, 0xae, 0x7c, 0x7d, 0xfc, 0x8a, 0xf5, 0x97, 0xa9, 0x39, 0x37, 0x27, 0x4e, 0xd9, 0xe8, 0xd0, 
+		0x8d, 0xa9, 0x32, 0xe4, 0x6b, 0xde, 0x76, 0x0f, 0xee, 0xf1, 0x22, 0x11, 0xc4, 0x1e, 0x4a, 0x01, 
+		0x73, 0xc4, 0x34, 0x8c, 0x4d, 0x16, 0xf1, 0x2f, 0x5f, 0xe4, 0xe5, 0x41, 0x3a, 0x3b, 0xf1, 0xb1, 
+		0x78, 0x7c, 0x0e, 0x55, 0xf9, 0xf7, 0xcf, 0x64, 0x93, 0xad, 0x77, 0xfd, 0x31, 0x52, 0x87
+	]
+	let privateKeyData = Data(privateKeyBytes)
+
+	let keyAttributes: [String: Any] = [
+		kSecAttrKeyType as String: kSecAttrKeyTypeRSA,
+		kSecAttrKeyClass as String: kSecAttrKeyClassPrivate,
+		kSecAttrKeySizeInBits as String: 1024,
+		kSecReturnPersistentRef as String: true
+	]
+
+	var error: Unmanaged<CFError>?
+	guard let privateKey = SecKeyCreateWithData(privateKeyData as CFData, keyAttributes as CFDictionary, &error) else {
+		completion("Failed to create private key: \(String(describing: error))")
+		return
+	}
+
+        guard let publicKey = SecKeyCopyPublicKey(privateKey) else {
+            completion("Failed to generate public key")
+            return
+        }
+
+        // Convert the public key to data (DER format)
+        guard let publicKeyData = SecKeyCopyExternalRepresentation(publicKey, &error) as Data? else {
+            completion("Failed to extract public key: \(String(describing: error))")
+            return
+        }
+
+        // Encode the public key for display
+        let publicKeyHex = publicKeyData.map { String(format: "%02hhx", $0) }.joined()
+
+        // Data to sign
+        let dataToSign = "This is a sample text".data(using: .utf8)!
+
+        // Step 2: Sign the data with the hardcoded private key
+        guard let signature = SecKeyCreateSignature(
+            privateKey,
+            SecKeyAlgorithm.rsaSignatureMessagePKCS1v15SHA256,
+            dataToSign as CFData,
+            &error
+        ) else {
+            completion("Signing failed: \(String(describing: error))")
+            return
+        }
+
+        // Convert signature to hex string for display
+        let signatureHex = (signature as Data).map { String(format: "%02hhx", $0) }.joined()
+
+        // Step 3: Verify the signature with the public key
+        let verificationStatus = SecKeyVerifySignature(
+            publicKey,
+            SecKeyAlgorithm.rsaSignatureMessagePKCS1v15SHA256,
+            dataToSign as CFData,
+            signature as CFData,
+            &error
+        )
+
+        let verificationResult = verificationStatus ? "Signature is valid." : "Signature is invalid."
+
+        let value = """
+        Original: \(String(data: dataToSign, encoding: .utf8)!)
+        
+        Public Key (Hex): \(publicKeyHex)
+        
+        Signature (Hex): \(signatureHex)
+        
+        Verification: \(verificationResult)
+        """
+
+        completion(value)
+    }
+}