Calling close in the CONNECTING state should not cause onopen t…

…o be called (#383) * test: assert that calling `close` in the `CONNECTING` state does not cause `onopen` to be called * fix: bail from the `WebSocket` constructor's delayed setup if the `readyState` has changed from `CONNECTING` to something else
thoov · Sep 11, 2023 · b098586 · b098586
1 parent df592e1
commit b098586
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/websocket.js b/src/websocket.js
@@ -51,6 +51,9 @@ class WebSocket extends EventTarget {
      * registered :-)
      */
     delay(function delayCallback() {
+      if (this.readyState !== WebSocket.CONNECTING) {
+        return;
+      }
       if (server) {
         if (
           server.options.verifyClient &&

diff --git a/tests/functional/close-algorithm.test.js b/tests/functional/close-algorithm.test.js
@@ -88,6 +88,10 @@ test.cb('that if the readyState is CONNECTING we fail the connection and close',
 
   mockSocket.readyState = WebSocket.CONNECTING;
 
+  mockSocket.onopen = () => {
+    t.fail('open should not have been called');
+  };
+
   mockSocket.onerror = () => {
     t.is(mockSocket.readyState, WebSocket.CLOSED);
   };