Fixed bug where analytics.js was not loaded.

thomaswelton · Jan 4, 2014 · 25c9d33 · 25c9d33
1 parent aac7114
commit 25c9d33
Show file tree

Hide file tree

Showing 6 changed files with 29 additions and 6 deletions.
diff --git a/Gruntfile.coffee b/Gruntfile.coffee
@@ -189,7 +189,7 @@ module.exports = (grunt) =>
                     mainConfigFile: '<%= pkg.temp %>/main.js'
                     out: '<%= pkg.temp %>/optimized.js'
                     optimize: 'none'
-                    findNestedDependencies: true
+                    findNestedDependencies: false # Does not work with this enabled
 
         # grunt-contrib-watch: https://github.com/gruntjs/grunt-contrib-watch
         # Run predefined tasks whenever watched file patterns are added, changed or deleted.

diff --git a/README.md b/README.md
@@ -30,7 +30,7 @@ Installation via bower
 ```json
 {
   "dependencies": {
-  	"requirejs-google-analytics": "~0.1.7"
+  	"requirejs-google-analytics": "~0.1.9"
   }
 }
 ```

diff --git a/dist/GoogleAnalytics.js b/dist/GoogleAnalytics.js
diff --git a/dist/README.html b/dist/README.html
@@ -135,7 +135,7 @@ <h2 id="installation">Installation</h2>
 <p>Installation via bower</p>
 <pre><code class="lang-json">{
   &quot;dependencies&quot;: {
-      &quot;requirejs-google-analytics&quot;: &quot;~0.1.7&quot;
+      &quot;requirejs-google-analytics&quot;: &quot;~0.1.9&quot;
   }
 }</code></pre>
 <h2 id="usage">Usage</h2>

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "requirejs-google-analytics",
   "description": "Google Analytics loader",
-  "version": "0.1.7",
+  "version": "0.1.9",
   "scripts": {
     "test": "grunt travis --verbose"
   },

diff --git a/src/GoogleAnalytics.litcoffee b/src/GoogleAnalytics.litcoffee
@@ -7,6 +7,18 @@ Strict helps to trap more potential bugs.
 
     'use strict'
 
+Load
+[Google Analytics](https://developers.google.com/analytics/devguides/collection/analyticsjs/)
+using requirejs.
+Feel free to just use this snippet for a lightweight implementation.
+
+    require.config
+        paths:
+            'ga': '//www.google-analytics.com/analytics'
+        shim:
+            'ga':
+                exports: 'ga'
+
 `module` is used to retrieve the
 [configuration](http://requirejs.org/docs/api.html#config-moduleconfig) and
 [EventEmitter](https://github.com/thomaswelton/bower-event-emitter) is used
@@ -39,7 +51,7 @@ Set the chosen variation for the Visitor for
 
                 unless @config.ga
                     # Load the actual Google Analytics library
-                    require ['//www.google-analytics.com/analytics'], (@ga) =>
+                    require ['ga'], (@ga) =>
                         @fireEvent 'ready', @ga
                 else
                     @ga = @config.ga