Fix erroneous URL encoding of query parameters #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`quote` is redundant since we anyway `urlencode(parameters)` at the end.
|
I didn't see that there was someone who had this same problem. #393 I tried your solution and it works. |
|
Actually the double encoding relies on previously buggy behavior of REST API which decodes twice. firebase/firebase-admin-python#189. State of python client is dismal. Admin SDK has various bug fixes and perf improvements while only pyrebase supports client authentication. Looks like I'll be migrating to Node.js in future, though PubNub looks promising for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quoteis redundant since we anywayurlencode(parameters)at the end.