chore: Fix readContract docs #4920

kien-ngo · 2024-10-04T11:28:43Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR updates the useReadContract function calls in two files to properly format the method string by adding a trailing comma. This change ensures consistency and correctness in the function's parameters.

Detailed summary

In packages/thirdweb/src/transaction/read-contract.ts:
- Added a trailing comma to the method string in useReadContract.
In packages/thirdweb/src/react/core/hooks/contract/useReadContract.ts:
- Added a trailing comma to the method string in useReadContract.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

vercel · 2024-10-04T11:28:47Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 2:20am
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 2:20am
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 2:20am
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 5, 2024 2:20am

changeset-bot · 2024-10-04T11:28:47Z

⚠️ No Changeset found

Latest commit: 5c6f288

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

graphite-app · 2024-10-04T11:28:49Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

packages/thirdweb/src/react/core/hooks/contract/useReadContract.ts

github-actions · 2024-10-04T11:32:14Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	42.1 KB (0%)	842 ms (0%)	280 ms (-33.42% 🔽)	1.2 s
thirdweb (cjs)	101.73 KB (0%)	2.1 s (0%)	648 ms (-17.48% 🔽)	2.7 s
thirdweb (minimal + tree-shaking)	4.82 KB (0%)	97 ms (0%)	97 ms (+298.02% 🔺)	193 ms
thirdweb/chains (tree-shaking)	498 B (0%)	10 ms (0%)	15 ms (+267.83% 🔺)	25 ms
thirdweb/react (minimal + tree-shaking)	17.23 KB (0%)	345 ms (0%)	105 ms (+121.38% 🔺)	449 ms

codecov · 2024-10-04T12:00:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.61%. Comparing base (4660e0c) to head (5c6f288).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4920   +/-   ##
=======================================
  Coverage   47.61%   47.61%           
=======================================
  Files        1057     1057           
  Lines       57241    57241           
  Branches     3926     3925    -1     
=======================================
  Hits        27256    27256           
  Misses      29296    29296           
  Partials      689      689

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 4660e0c
packages	`43.37% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...b/src/react/core/hooks/contract/useReadContract.ts	`47.91% <ø> (ø)`
packages/thirdweb/src/transaction/read-contract.ts	`75.71% <ø> (ø)`

... and 2 files with indirect coverage changes

joaquim-verges · 2024-10-04T19:10:37Z

packages/thirdweb/src/transaction/read-contract.ts

@@ -111,7 +111,7 @@ export type ReadContractOptions<
 *
 * const { data, isLoading } = useReadContract({
 *   contract,
- *   method: "function tokenURI(uint256 tokenId) returns (string)"}),
+ *   method: "function tokenURI(uint256 tokenId) returns (string)"),


good bot :D

Ser. Still wrong here

hmm? i updated the code ser

There's still an extra ')' in there at the end no?

I think the bot comment got us confused. I did update this part, can no longer see the extra ")" in the code

the comment should resolved on itself, but since we are using this thread maybe thats why it did

Oh yeah that must be it. Looks fine on gh

joaquim-verges

good bot

packages/thirdweb/src/react/core/hooks/contract/useReadContract.ts

graphite-app · 2024-10-05T02:07:37Z

Merge activity

Oct 4, 10:07 PM EDT: MananTank added this pull request to the Graphite merge queue.
Oct 4, 10:19 PM EDT: MananTank merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR focuses on updating the `useReadContract` function calls in two files by adding a comma to the method definition for better syntax clarity. ### Detailed summary - In `packages/thirdweb/src/transaction/read-contract.ts`: - Added a comma after the method definition for `tokenURI`. - In `packages/thirdweb/src/react/core/hooks/contract/useReadContract.ts`: - Added a comma after the method definition for `tokenURI`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

kien-ngo requested review from joaquim-verges, gregfromstl, MananTank, jnsdls and edwardysun as code owners October 4, 2024 11:28

kien-ngo self-assigned this Oct 4, 2024

github-actions bot added the packages label Oct 4, 2024

graphite-app bot reviewed Oct 4, 2024

View reviewed changes

packages/thirdweb/src/react/core/hooks/contract/useReadContract.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview – wallet-ui October 4, 2024 11:30 View deployment

vercel bot deployed to Preview – thirdweb_playground October 4, 2024 11:31 View deployment

vercel bot deployed to Preview – thirdweb-www October 4, 2024 11:38 View deployment

vercel bot deployed to Preview – docs-v2 October 4, 2024 11:38 View deployment

MananTank approved these changes Oct 4, 2024

View reviewed changes

joaquim-verges reviewed Oct 4, 2024

View reviewed changes

joaquim-verges requested changes Oct 4, 2024

View reviewed changes

graphite-app bot reviewed Oct 4, 2024

View reviewed changes

packages/thirdweb/src/react/core/hooks/contract/useReadContract.ts Outdated Show resolved Hide resolved

vercel bot deployed to Preview – wallet-ui October 4, 2024 23:59 View deployment

vercel bot deployed to Preview – wallet-ui October 5, 2024 00:03 View deployment

vercel bot deployed to Preview – thirdweb_playground October 5, 2024 00:03 View deployment

vercel bot deployed to Preview – thirdweb-www October 5, 2024 00:15 View deployment

kien-ngo requested a review from joaquim-verges October 5, 2024 00:15

vercel bot deployed to Preview – docs-v2 October 5, 2024 00:20 View deployment

joaquim-verges approved these changes Oct 5, 2024

View reviewed changes

MananTank force-pushed the kien/fix-docs-oct-4 branch from 6bd8f46 to 5c6f288 Compare October 5, 2024 02:08

vercel bot deployed to Preview – wallet-ui October 5, 2024 02:10 View deployment

vercel bot deployed to Preview – thirdweb_playground October 5, 2024 02:11 View deployment

vercel bot deployed to Preview – thirdweb-www October 5, 2024 02:18 View deployment

graphite-app bot merged commit 5c6f288 into main Oct 5, 2024
30 of 31 checks passed

graphite-app bot deleted the kien/fix-docs-oct-4 branch October 5, 2024 02:19

vercel bot deployed to Preview – docs-v2 October 5, 2024 02:20 View deployment

vercel bot deployed to Production – wallet-ui October 5, 2024 02:21 View deployment

vercel bot deployed to Production – thirdweb_playground October 5, 2024 02:21 View deployment

vercel bot deployed to Production – docs-v2 October 5, 2024 02:22 View deployment

vercel bot deployed to Production – thirdweb-www October 5, 2024 02:29 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Fix readContract docs #4920

chore: Fix readContract docs #4920

kien-ngo commented Oct 4, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 4, 2024 •

edited

Loading

changeset-bot bot commented Oct 4, 2024 •

edited

Loading

graphite-app bot commented Oct 4, 2024

github-actions bot commented Oct 4, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading

joaquim-verges Oct 4, 2024

joaquim-verges Oct 4, 2024

joaquim-verges Oct 5, 2024

kien-ngo Oct 5, 2024

joaquim-verges Oct 5, 2024

kien-ngo Oct 5, 2024

kien-ngo Oct 5, 2024

joaquim-verges Oct 5, 2024

joaquim-verges left a comment

graphite-app bot commented Oct 5, 2024 •

edited

Loading

chore: Fix readContract docs #4920

chore: Fix readContract docs #4920

Conversation

kien-ngo commented Oct 4, 2024 • edited by pr-codex bot Loading

Problem solved

PR-Codex overview

Detailed summary

vercel bot commented Oct 4, 2024 • edited Loading

changeset-bot bot commented Oct 4, 2024 • edited Loading

⚠️ No Changeset found

graphite-app bot commented Oct 4, 2024

Your org has enabled the Graphite merge queue for merging into main

github-actions bot commented Oct 4, 2024 • edited Loading

size-limit report 📦

codecov bot commented Oct 4, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joaquim-verges left a comment

Choose a reason for hiding this comment

graphite-app bot commented Oct 5, 2024 • edited Loading

Merge activity

kien-ngo commented Oct 4, 2024 •

edited by pr-codex bot

Loading

vercel bot commented Oct 4, 2024 •

edited

Loading

changeset-bot bot commented Oct 4, 2024 •

edited

Loading

github-actions bot commented Oct 4, 2024 •

edited

Loading

codecov bot commented Oct 4, 2024 •

edited

Loading

graphite-app bot commented Oct 5, 2024 •

edited

Loading