-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move gas and timeout details to Engine FAQ #4914
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4914 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 1057 1057
Lines 57221 57221
Branches 3924 3924
=======================================
Hits 27246 27246
Misses 29286 29286
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
<!-- start pr-codex --> ## PR-Codex overview This PR focuses on updating the documentation for transaction settings in the `Engine` feature. It clarifies the structure and usage of `txOverrides` for sending native currency and overriding gas settings, including examples and warnings about transaction timeouts. ### Detailed summary - Changed keys in `txOverrides` from unquoted to quoted strings in the JSON structure. - Added a section on sending native currency with examples. - Introduced a section on overriding gas settings with examples. - Included a warning about setting a timeout for transactions. - Added a section on specifying transaction timeouts with examples. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
38c5417
to
b2276e9
Compare
PR-Codex overview
This PR updates the documentation in
page.mdx
files related to transaction overrides in the Engine. It includes changes to the JSON format and adds new sections on sending native currency, overriding gas settings, and setting transaction timeouts.Detailed summary
txOverrides
.txOverrides.value
.txOverrides.timeoutSeconds
.