Move /connect/in-app-wallets to app router #4894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Oct 2, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MananTank and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4894 +/- ##
=======================================
Coverage 47.61% 47.61%
=======================================
Files 1057 1057
Lines 57221 57221
Branches 3924 3924
=======================================
Hits 27246 27246
Misses 29286 29286
Partials 689 689
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
MananTank
force-pushed
the
10-03-move__connect_analytics_to_app_router
branch
from
f95fa52
to
f20b046
Compare
MananTank
force-pushed
the
10-03-move__connect_in-app-wallets_to_app_router
branch
from
d2d37d1
to
d898e86
Compare
MananTank
force-pushed
the
10-03-move__connect_in-app-wallets_to_app_router
branch
from
d898e86
to
9f2b083
Compare
jnsdls
force-pushed
the
10-03-move__connect_analytics_to_app_router
branch
2 times, most recently
from
9382059
to
22ee12e
Compare
jnsdls
force-pushed
the
10-03-move__connect_in-app-wallets_to_app_router
branch
from
9f2b083
to
ff5b14a
Compare
jnsdls
requested changes
Oct 3, 2024
apps/dashboard/src/app/(dashboard)/dashboard/connect/in-app-wallets/[clientId]/page.tsx
Outdated
Show resolved
Hide resolved
MananTank
force-pushed
the
10-03-move__connect_in-app-wallets_to_app_router
branch
from
6e09ef9
to
7b11876
Compare
MananTank
force-pushed
the
graphite-base/4894
branch
from
b70a030
to
615dd1e
Compare
MananTank
force-pushed
the
10-03-move__connect_in-app-wallets_to_app_router
branch
from
7b11876
to
23cd49d
Compare
MananTank
force-pushed
the
10-03-move__connect_in-app-wallets_to_app_router
branch
from
23cd49d
to
d8ff07e
Compare
jnsdls
approved these changes
Oct 3, 2024
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on enhancing the `in-app-wallets` feature by adding new components and functionalities, including API key management and layout improvements.
### Detailed summary
- Added `getInAppWalletSupportedAPIKeys` function to fetch and filter API keys.
- Created `Layout` component with footer sections.
- Implemented `InAppWalletsAPIKeysMenu` for API key selection.
- Added `PageHeader` with description and link.
- Enhanced `Page` component to handle redirects and display API keys.
- Updated `EmbeddedWallets` component to use `defaultTab` prop instead of search params.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
jnsdls
force-pushed
the
10-03-move__connect_in-app-wallets_to_app_router
branch
from
d8ff07e
to
b82011e
Compare
graphite-app
bot
deleted the
10-03-move__connect_in-app-wallets_to_app_router
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces a new
in-app-walletsfeature to the dashboard, including support for API keys, a layout for the wallet interface, and a header component. It also refines navigation and user experience for managing in-app wallets.Detailed summary
getInAppWalletSupportedAPIKeysfunction to fetch API keys.Layoutcomponent for the wallet interface.InAppWalletsAPIKeysMenufor API key selection.PageHeadercomponent for in-app wallets page.Pageto handle authentication and API key redirects.EmbeddedWalletscomponent to use a default tab.