-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard] Remove VStack - Need test so do not merge #4727
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
@@ -18,7 +18,7 @@ export const AvatarShowcase: React.FC<AvatarShowcaseProps> = ({ | |||
trackingCategory, | |||
}) => { | |||
return ( | |||
<VStack spacing={12}> | |||
<div className="flex flex-col spacing-y-12"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mind the gap
2312b72
to
8fff768
Compare
52d3453
to
9addb90
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## kien/erc20-airdrop-form #4727 +/- ##
===========================================================
+ Coverage 48.92% 50.69% +1.76%
===========================================================
Files 1050 1024 -26
Lines 57002 54469 -2533
Branches 3892 3889 -3
===========================================================
- Hits 27889 27613 -276
+ Misses 28480 26223 -2257
Partials 633 633
*This pull request uses carry forward flags. Click here to find out more. |
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
The focus of this PR is to replace the
VStack
components withdiv
elements in multiple files for better styling and layout control.Detailed summary
VStack
withdiv
inOnboardingTitle
,JudgesEarn
,AvatarShowcase
, and more components for styling.Flex
andSimpleGrid
inJudgesEarn
andJudges
components.VStack
withdiv
inReceiveFundsModal
,UploadStep
, and more components for consistent styling.VStack
import inBillingPeriod
andOnboardingGeneral
components.