Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Remove VStack - Need test so do not merge #4727

Closed
wants to merge 1 commit into from

Conversation

kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Sep 20, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

The focus of this PR is to replace the VStack components with div elements in multiple files for better styling and layout control.

Detailed summary

  • Replaced VStack with div in OnboardingTitle, JudgesEarn, AvatarShowcase, and more components for styling.
  • Updated import statements for Flex and SimpleGrid in JudgesEarn and Judges components.
  • Replaced VStack with div in ReceiveFundsModal, UploadStep, and more components for consistent styling.
  • Removed VStack import in BillingPeriod and OnboardingGeneral components.

The following files were skipped due to too many changes: apps/dashboard/src/components/onboarding/Steps.tsx, apps/dashboard/src/components/settings/Account/AccountForm.tsx, apps/dashboard/src/components/settings/Account/Usage.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2024 1:06pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 21, 2024 1:06pm
thirdweb_playground ⬜️ Skipped (Inspect) Sep 21, 2024 1:06pm
wallet-ui ⬜️ Skipped (Inspect) Sep 21, 2024 1:06pm

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: 9addb90

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 September 20, 2024 18:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground September 20, 2024 18:34 Inactive
Copy link

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – wallet-ui September 20, 2024 18:34 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Sep 20, 2024
Copy link
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @kien-ngo and the rest of your teammates on Graphite Graphite

@kien-ngo kien-ngo changed the title Update [Dashboard] Remove VStack - Need test so do not merge Sep 20, 2024
@kien-ngo kien-ngo marked this pull request as ready for review September 20, 2024 18:35
@kien-ngo kien-ngo added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Sep 20, 2024 — with Graphite App
@kien-ngo kien-ngo self-assigned this Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 43.67 KB (0%) 874 ms (0%) 756 ms (+112.48% 🔺) 1.7 s
thirdweb (cjs) 101.2 KB (0%) 2.1 s (0%) 1.1 s (+19.29% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 4.85 KB (0%) 98 ms (0%) 70 ms (+49.94% 🔺) 167 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 58 ms (+394.84% 🔺) 68 ms
thirdweb/react (minimal + tree-shaking) 16.72 KB (0%) 335 ms (0%) 107 ms (-25.8% 🔽) 442 ms

@@ -18,7 +18,7 @@ export const AvatarShowcase: React.FC<AvatarShowcaseProps> = ({
trackingCategory,
}) => {
return (
<VStack spacing={12}>
<div className="flex flex-col spacing-y-12">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind the gap

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.69%. Comparing base (8fff768) to head (9addb90).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           kien/erc20-airdrop-form    #4727      +/-   ##
===========================================================
+ Coverage                    48.92%   50.69%   +1.76%     
===========================================================
  Files                         1050     1024      -26     
  Lines                        57002    54469    -2533     
  Branches                      3892     3889       -3     
===========================================================
- Hits                         27889    27613     -276     
+ Misses                       28480    26223    -2257     
  Partials                       633      633              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 8fff768
packages 46.95% <ø> (+1.98%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 42 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants