[WIP] Project intergalactic - Fiat flow #4714

edwardysun · 2024-09-19T22:57:15Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR introduces enhancements to the buyWithFiat functionality, allowing for the deployment of a smart wallet and improving the handling of onramp transactions. It updates payment options, RPC URLs, and integrates new hooks for better user experience.

Detailed summary

Added payOptions for buyWithFiat with preferredProvider.
Changed DEFAULT_RPC_URL from rpc.thirdweb.com to rpc.thirdweb-dev.com.
Enhanced FiatDetailsScreen with intentId.
Introduced isSingleStepExecutionEnabled in getQuote.ts.
Added state management for onRampLinkOverride in FiatFlow.tsx.
Updated FiatSteps to include smart wallet deployment logic.
Implemented useDeploySmartWallet hook for wallet deployment.
Integrated smart wallet deployment in FiatScreenContent.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

changeset-bot · 2024-09-19T22:57:18Z

⚠️ No Changeset found

Latest commit: 8afb2c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-09-19T22:57:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Updated (UTC)
docs-v2	❌ Failed (Inspect)	Sep 28, 2024 8:27am
thirdweb_playground	❌ Failed (Inspect)	Sep 28, 2024 8:27am
thirdweb-www	❌ Failed (Inspect)	Sep 28, 2024 8:27am
wallet-ui	❌ Failed (Inspect)	Sep 28, 2024 8:27am

graphite-app · 2024-09-19T22:57:21Z

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

github-actions · 2024-09-19T23:04:21Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	43.73 KB (+0.15% 🔺)	875 ms (+0.15% 🔺)	2.9 s (+11.85% 🔺)	3.8 s
thirdweb (cjs)	101.25 KB (+0.06% 🔺)	2.1 s (+0.06% 🔺)	5.1 s (-20.48% 🔽)	7.1 s
thirdweb (minimal + tree-shaking)	4.85 KB (+0.03% 🔺)	98 ms (+0.03% 🔺)	234 ms (+24.44% 🔺)	331 ms
thirdweb/chains (tree-shaking)	502 B (+0.81% 🔺)	10 ms (0%)	257 ms (+205.96% 🔺)	267 ms
thirdweb/react (minimal + tree-shaking)	16.73 KB (+0.07% 🔺)	335 ms (+0.07% 🔺)	479 ms (-10.02% 🔽)	813 ms

codecov · 2024-09-19T23:08:31Z

Codecov Report

Attention: Patch coverage is 9.47368% with 86 lines in your changes missing coverage. Please review.

Project coverage is 50.57%. Comparing base (0a7448c) to head (5142e8e).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...eb/ui/ConnectWallet/screens/Buy/fiat/FiatSteps.tsx	9.41%	77 Missing ⚠️
...web/ui/ConnectWallet/screens/Buy/fiat/FiatFlow.tsx	0.00%	8 Missing ⚠️
...screens/Buy/pay-transactions/FiatDetailsScreen.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4714      +/-   ##
==========================================
- Coverage   50.62%   50.57%   -0.05%     
==========================================
  Files        1025     1024       -1     
  Lines       54562    54629      +67     
  Branches     3893     3891       -2     
==========================================
+ Hits        27623    27630       +7     
- Misses      26306    26366      +60     
  Partials      633      633

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from ac45d90
packages	`46.82% <9.47%> (-0.06%)`	⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
packages/thirdweb/src/utils/domains.ts	`55.88% <100.00%> (ø)`
...screens/Buy/pay-transactions/FiatDetailsScreen.tsx	`7.27% <0.00%> (-0.07%)`	⬇️
...web/ui/ConnectWallet/screens/Buy/fiat/FiatFlow.tsx	`9.80% <0.00%> (-0.73%)`	⬇️
...eb/ui/ConnectWallet/screens/Buy/fiat/FiatSteps.tsx	`5.38% <9.41%> (+0.75%)`	⬆️

... and 3 files with indirect coverage changes

edwardysun · 2024-09-20T04:52:12Z

apps/playground-web/src/components/pay/embed.tsx

+        buyWithFiat: {
+          preferredProvider: "STRIPE",
+        },
+      }}


Remove before merging

edwardysun · 2024-09-20T04:52:26Z

packages/thirdweb/src/utils/domains.ts

@@ -34,7 +34,7 @@ type DomainOverrides = {
 export const DEFAULT_RPC_URL = "rpc.thirdweb.com";
 const DEFAULT_SOCIAL_URL = "social.thirdweb.com";
 const DEFAULT_IN_APP_WALLET_URL = "embedded-wallet.thirdweb.com";
-const DEFAULT_PAY_URL = "pay.thirdweb.com";
+const DEFAULT_PAY_URL = "pay.thirdweb-dev.com";


Change back

edwardysun · 2024-09-20T05:22:44Z

packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/fiat/FiatSteps.tsx

+  const account = useActiveAccount();
+  const switchChain = useSwitchActiveWalletChain();
+
+  const deploySmartWallet = async ({ chain }: { chain: Chain }) => {


needs to be better organized

edwardysun · 2024-09-20T05:24:11Z

packages/thirdweb/src/react/web/ui/ConnectWallet/screens/Buy/fiat/FiatSteps.tsx

+      sponsorGas: true,
+    });
+
+    const smartAccount = await smartWalletHandle.connect({


Right now, this creates a smart wallet that is deterministic to the account, but not per intent. How can I send in an intentId as the string to be deterministic by?

edwardysun · 2024-09-20T05:24:53Z

packages/thirdweb/src/utils/domains.ts

@@ -31,7 +31,7 @@ type DomainOverrides = {
  bundler?: string;
 };

-export const DEFAULT_RPC_URL = "rpc.thirdweb.com";
+export const DEFAULT_RPC_URL = "rpc.thirdweb-dev.com";


change back

edwardysun added 12 commits September 11, 2024 18:36

Add preferredProvider in buyWithFiat

8fd31f0

changeset

73faf7d

Update providerOverride param to preferredProvider

1338911

WIP - intergalactic

61cb684

Small cleanup

fa27a96

Merge branch 'main' into intergalactic-wip

020dbbf

Clean up

9f28a9c

Clean up

76943be

remove file

f24508f

Clean up

e05d389

Add onRampTokenAmount

1a6a338

nit

6049a4e

edwardysun added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Sep 19, 2024

edwardysun requested review from joaquim-verges, gregfromstl, jnsdls and MananTank as code owners September 19, 2024 22:57

github-actions bot added Playground Changes involving the Playground codebase. packages labels Sep 19, 2024

Add intentId

ac45d90

vercel bot deployed to Preview – thirdweb_playground September 19, 2024 23:06 View deployment

vercel bot deployed to Preview – wallet-ui September 19, 2024 23:09 View deployment

vercel bot deployed to Preview – thirdweb-www September 19, 2024 23:13 View deployment

vercel bot deployed to Preview – docs-v2 September 19, 2024 23:19 View deployment

use thirdweb-dev.com domain

5142e8e

vercel bot deployed to Preview – wallet-ui September 19, 2024 23:25 View deployment

vercel bot deployed to Preview – thirdweb_playground September 19, 2024 23:26 View deployment

vercel bot deployed to Preview – thirdweb-www September 19, 2024 23:31 View deployment

vercel bot deployed to Preview – docs-v2 September 19, 2024 23:34 View deployment

edwardysun commented Sep 20, 2024

View reviewed changes

apps/playground-web/src/components/pay/embed.tsx

buyWithFiat: {

preferredProvider: "STRIPE",

},

}}

Copy link

Member Author

edwardysun Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove before merging

edwardysun commented Sep 20, 2024

View reviewed changes

Update domains

55246f8

vercel bot deployed to Preview – thirdweb_playground September 20, 2024 05:02 View deployment

vercel bot deployed to Preview – wallet-ui September 20, 2024 05:02 View deployment

vercel bot deployed to Preview – thirdweb-www September 20, 2024 05:09 View deployment

vercel bot deployed to Preview – docs-v2 September 20, 2024 05:09 View deployment

edwardysun commented Sep 20, 2024

View reviewed changes

Updates

8afb2c4

vercel bot had a problem deploying to Preview – thirdweb-www September 28, 2024 08:26 Failure

vercel bot had a problem deploying to Preview – thirdweb_playground September 28, 2024 08:26 Failure

vercel bot had a problem deploying to Preview – docs-v2 September 28, 2024 08:27 Failure

vercel bot had a problem deploying to Preview – wallet-ui September 28, 2024 08:27 Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Project intergalactic - Fiat flow #4714

[WIP] Project intergalactic - Fiat flow #4714

edwardysun commented Sep 19, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Sep 19, 2024 •

edited

Loading

vercel bot commented Sep 19, 2024 •

edited

Loading

graphite-app bot commented Sep 19, 2024

github-actions bot commented Sep 19, 2024 •

edited

Loading

codecov bot commented Sep 19, 2024 •

edited

Loading

edwardysun Sep 20, 2024

edwardysun Sep 20, 2024

edwardysun Sep 20, 2024

edwardysun Sep 20, 2024

edwardysun Sep 20, 2024

[WIP] Project intergalactic - Fiat flow #4714

Are you sure you want to change the base?

[WIP] Project intergalactic - Fiat flow #4714

Conversation

edwardysun commented Sep 19, 2024 • edited by pr-codex bot Loading

Problem solved

PR-Codex overview

Detailed summary

changeset-bot bot commented Sep 19, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Sep 19, 2024 • edited Loading

graphite-app bot commented Sep 19, 2024

Your org has enabled the Graphite merge queue for merging into main

github-actions bot commented Sep 19, 2024 • edited Loading

size-limit report 📦

codecov bot commented Sep 19, 2024 • edited Loading

Codecov Report

edwardysun Sep 20, 2024

Choose a reason for hiding this comment

edwardysun Sep 20, 2024

Choose a reason for hiding this comment

edwardysun Sep 20, 2024

Choose a reason for hiding this comment

edwardysun Sep 20, 2024

Choose a reason for hiding this comment

edwardysun Sep 20, 2024

Choose a reason for hiding this comment

edwardysun commented Sep 19, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Sep 19, 2024 •

edited

Loading

vercel bot commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024 •

edited

Loading

codecov bot commented Sep 19, 2024 •

edited

Loading