improve getNFTs behavior

thirdweb-dev · Feb 26, 2024 · ab035bd · ab035bd
1 parent 76d48ae
commit ab035bd
Show file tree

Hide file tree

Showing 4 changed files with 399 additions and 4 deletions.
diff --git a/packages/thirdweb/package.json b/packages/thirdweb/package.json
@@ -197,6 +197,7 @@
     "test:watch": "vitest -c ./test/vitest.config.ts dev",
     "test": "CI=true vitest -c ./test/vitest.config.ts --coverage --retry=3 --bail=1 --pool=forks",
     "test:cov": "vitest dev -c ./test/vitest.config.ts --coverage",
+    "test:dev": "vitest dev -c ./test/vitest.config.ts",
     "typedoc": "node scripts/typedoc.mjs",
     "update-version": "node scripts/version.mjs"
   },

diff --git a/packages/thirdweb/src/extensions/erc721/read/getNFT.ts b/packages/thirdweb/src/extensions/erc721/read/getNFT.ts
@@ -34,18 +34,34 @@ export async function getNFT(
   options: BaseTransactionOptions<GetNFTParams>,
 ): Promise<NFT<"ERC721">> {
   const [uri, owner] = await Promise.all([
-    tokenURI(options),
+    tokenURI(options).catch(() => null),
     options.includeOwner
-      ? import("./ownerOf.js").then((m) => m.ownerOf(options))
+      ? import("./ownerOf.js").then((m) => m.ownerOf(options)).catch(() => null)
       : null,
   ]);
 
+  if (!uri) {
+    return parseNFT(
+      {
+        id: options.tokenId,
+        type: "ERC721",
+        uri: "",
+      },
+      {
+        tokenId: options.tokenId,
+        tokenUri: "",
+        type: "ERC721",
+        owner,
+      },
+    );
+  }
+
   return parseNFT(
     await fetchTokenMetadata({
       client: options.contract.client,
       tokenId: options.tokenId,
       tokenUri: uri,
-    }),
+    }).catch(() => {}),
     {
       tokenId: options.tokenId,
       tokenUri: uri,