Skip to content

Commit

Permalink
fix: add missing partner id for ecosystem wallet (#4886)
Browse files Browse the repository at this point in the history
## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on fixing the issue of missing `partnerId` when creating an ecosystem wallet in the `thirdweb` package.

### Detailed summary
- Updated `partnerId` in `packages/thirdweb/src/wallets/in-app/web/ecosystem.ts` to use `ecosystem.partnerId`.
- Updated `partnerId` in `packages/thirdweb/src/wallets/in-app/native/ecosystem.ts` to use `createOptions?.partnerId`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
  • Loading branch information
ElasticBottle committed Oct 2, 2024
1 parent 9fb5401 commit 985c4b0
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/famous-spies-grab.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

fix missing partner id when creating ecosystem wallet
1 change: 1 addition & 0 deletions packages/thirdweb/src/wallets/in-app/native/ecosystem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ export function ecosystemWallet(
...createOptions?.auth,
options: [], // controlled by ecosystem
},
partnerId: createOptions?.partnerId,
},
connectorFactory: async (client: ThirdwebClient) => {
const { InAppNativeConnector } = await import("./native-connector.js");
Expand Down
1 change: 1 addition & 0 deletions packages/thirdweb/src/wallets/in-app/web/ecosystem.ts
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ export function ecosystemWallet(
...createOptions?.auth,
options: [], // controlled by ecosystem
},
partnerId: ecosystem.partnerId,
},
connectorFactory: async (client: ThirdwebClient) => {
const { InAppWebConnector } = await import("./lib/web-connector.js");
Expand Down

0 comments on commit 985c4b0

Please sign in to comment.