Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting the Io_scheduler structure #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joseims
Copy link
Contributor

@joseims joseims commented May 29, 2019

Scheduler and Disk as simple classes

Copy link
Owner

@thiagomanel thiagomanel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a batch of small sugestions

self.track_size=track_size
self.current_position = 0

def distance(self,new_position):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace new_position by position

@@ -0,0 +1,7 @@
class Disk:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add spaces in the proper places self.track_size=track_size self.track_size = track_size

self.current_position = 0

def distance(self,new_position):
return (self.current_position - new_position)%self.track_size
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs an extra space too


class Random_scheduler(Scheduler):
def schedule(queue):
return r.randint(0,len(queue))
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is expected to change the queue (remove the item index by the r.randint(0,len(queue)) (if the queue is not empty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants