-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Starting the Io_scheduler structure #10
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a batch of small sugestions
io_scheduling/disk.py
Outdated
self.track_size=track_size | ||
self.current_position = 0 | ||
|
||
def distance(self,new_position): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace new_position by position
@@ -0,0 +1,7 @@ | |||
class Disk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add spaces in the proper places self.track_size=track_size
self.track_size = track_size
io_scheduling/disk.py
Outdated
self.current_position = 0 | ||
|
||
def distance(self,new_position): | ||
return (self.current_position - new_position)%self.track_size |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs an extra space too
io_scheduling/scheduler.py
Outdated
|
||
class Random_scheduler(Scheduler): | ||
def schedule(queue): | ||
return r.randint(0,len(queue)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is expected to change the queue (remove the item index by the r.randint(0,len(queue)) (if the queue is not empty)
Scheduler and Disk as simple classes