Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thumbnail_url property for Mapit Places #245

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Conversation

zarino
Copy link
Contributor

@zarino zarino commented Dec 18, 2018

Adds a thumbnail_url property for Mapit Places, which checks for the presence of a thumbnail file in /public/images/thumbnails matching the place’s pombola_slug, and returns the URL if found, otherwise the default "pin" placeholder.

Commit also includes thumbnail images for the 37 top-level states.

Fixes #226.

image

Plus a full set of thumbnail images for States!
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 99.72% when pulling 33b0b01 on 226-images-for-states into 8942814 on master.

Copy link
Contributor

@chrismytton chrismytton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@zarino zarino merged commit 33b0b01 into master Dec 18, 2018
@ghost ghost removed the 4 - Reviewing label Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants