-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the finder return only published documents #158
Open
octopusinvitro
wants to merge
7
commits into
master
Choose a base branch
from
scrape-unlinked-pages
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jul 12, 2017
-
Configuration menu - View commit details
-
Copy full SHA for cf06306 - Browse repository at this point
Copy the full SHA cf06306View commit details -
Add a method to finder to find unpublished documents
This method allows the scraper route to send the unpublished documents to the view so that they can be scraped and pushed to the static repo. Documents that are unpublished are not linked anywhere on the site. With this change, they can be loaded as a preview without being explicitly linked from the site. This means that all documents, linked or unlinked, are published.
Configuration menu - View commit details
-
Copy full SHA for 588dccd - Browse repository at this point
Copy the full SHA 588dccdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7532f22 - Browse repository at this point
Copy the full SHA 7532f22View commit details -
Configuration menu - View commit details
-
Copy full SHA for c742f35 - Browse repository at this point
Copy the full SHA c742f35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 822dc98 - Browse repository at this point
Copy the full SHA 822dc98View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcc5bc2 - Browse repository at this point
Copy the full SHA fcc5bc2View commit details -
Add point under tribal knowledge section: everything is published.
There is a small nuance between "published" documents and "unlinked" documents that may not be obvious to a newcomer to the codebase. So an explanation was filled under the tribal knowledge section of the contributing guide.
Configuration menu - View commit details
-
Copy full SHA for e7e0ad0 - Browse repository at this point
Copy the full SHA e7e0ad0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.