minor fixes to both coastline, boundary shpfiles and meshing script. #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jhill1 : sorry, didn't see you already had a PR open on the North Sea example. We would need to merge with #344 for this to work (and you probably need to regenerate the bathymetry checkpoint file as I see the mesh has changed). I think this PR looks good. The README in this example should probably be updated to point to where to get qmesh3 from?
Is this still ongoing? Does this refer to https://bitbucket.org/qmesh-developers/qmesh/pull-requests/6 ? If you need more time, I would prefer to merge #344 first: the example doesn't run at all at the moment (and isn't even tested!) which really should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue #328 so that the generate_mesh.py script now works as expected. Note qmesh will need updating to 1.04 (pending)