Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing lock in tx.go #207

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Missing lock in tx.go #207

wants to merge 1 commit into from

Commits on Sep 20, 2023

  1. Missing lock in tx.go 

    There is a missing lock in tx.go , after the transaction is done via the RPC , the wallet is not locked hence its kept open to be used without password. If the RPC is exposed an attacker can make tx request without password as the wallet is unlocked. It is recommended to put defer lock , after the tx is executed.
    @mabdullah22
    mabdullah22 committed Sep 20, 2023
    Configuration menu
    Copy the full SHA
    e221500 View commit details
    Browse the repository at this point in the history