Tools: Testbench: Add to IPC4 version UUID based components load, apply initial byte control, etc. #9542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch copies similar change from SOF plugin. The load of host copier, DAI copier, PGA, and process components are updated to use UUID that is appended to end of IPC4 base module configuration and other component specific init IPC. Signed-off-by: Seppo Ingalsuo <[email protected]>
This adds find or byte controls and set to components after initialize. Also other control types mixer, switch, enum are parsed but not yet applied to components. The code is copied and adapted from SOF plugin. Signed-off-by: Seppo Ingalsuo <[email protected]>
If kept in src_common.h the inclusion to tplg_parser would create need to include even more headers from SOF. The simple src_ipc.h contains the only needed SRC IPC4 definition. The __SOF_AUDIO_SRC_SRC_H__ is updated to match header name and the ending #endif is moved file end where it should be. Signed-off-by: Seppo Ingalsuo <[email protected]>
This replaces for IPC4 testbench the previous non-working version that was a copy of IPC3 version. Signed-off-by: Seppo Ingalsuo <[email protected]>
This replaces for IPC4 testbench the previous non-working version that was a copy of IPC3 version. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
requested review from
ranj063,
abonislawski,
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
lgirdwood
reviewed
Oct 3, 2024
| @@ -52,6 +55,27 @@ struct tb_config { | |||
| int channels; | |||
| unsigned long format; | |||
| }; | |||
|
|
|||
| struct tb_ctl { | |||
There was a problem hiding this comment.
Can we include the ABI header rather than duplicate ? I guess this comes from ALSA asoc.h ?
|
|
||
| /* src component private data */ | ||
| struct ipc4_config_src { | ||
| struct ipc4_base_module_cfg base; |
There was a problem hiding this comment.
Should we have size at the start ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build and run IPC4 topologies, this needs PRs #9536, #9538. #9501 is needed if the topology is not containing blobs for byte controls (usually they do).