ASoC: SOF: IPC4: LunarLake: allow ALH chain-dma #4526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The chain_dma mode is currently only handled for HDaudio, but can be used for orther DAIs starting with LunarLake. Move the chain_dma handling earlier. Error detection for the chain_dma case for older platforms is handled at a different level. Signed-off-by: Pierre-Louis Bossart <[email protected]>
ranj063
reviewed
Aug 15, 2023
sound/soc/sof/ipc4-topology.c
Outdated
| @@ -517,10 +517,12 @@ static int sof_ipc4_widget_setup_comp_dai(struct snd_sof_widget *swidget) | |||
|
|
|||
| pipe_widget = swidget->spipe->pipe_widget; | |||
| pipeline = pipe_widget->private; | |||
| if (pipeline->use_chain_dma && ipc4_copier->dai_type != SOF_DAI_INTEL_HDA) { | |||
| if (pipeline->use_chain_dma && | |||
| (ipc4_copier->dai_type != SOF_DAI_INTEL_HDA) || | |||
There was a problem hiding this comment.
yes indeed. Need more coffee and a new brain.
We need to find a way to make this conditional on the platform, maybe with a dai_ops .is_chain_dma_supported callback? Signed-off-by: Pierre-Louis Bossart <[email protected]>
Use the existing callbacks and mix/match of HDaudio and SoundWire support. Signed-off-by: Pierre-Louis Bossart <[email protected]>
plbossart
force-pushed
the
fix/lnl-alh-chain-dma
branch
from
cf8ef1d
to
8810cc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
completely untested draft to see how we could enable the chain DMA for SoundWire on LunarLake - in theory we can use the same framework now that the same HDAudio DMA is used.